* [pci:controller/rockchip 1/3] drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe'
@ 2025-01-06 11:39 Dan Carpenter
2025-01-06 15:38 ` Anand Moon
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-01-06 11:39 UTC (permalink / raw)
To: oe-kbuild, Anand Moon
Cc: lkp, oe-kbuild-all, linux-pci, Lorenzo Pieralisi,
Manivannan Sadhasivam
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
head: 8261bf695c47b98a2d8f63e04e2fc2e4a8c6b12b
commit: fa0ce454cd4ee35703d4126c5b8e4a9a398cf198 [1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function
config: arm64-randconfig-r073-20250102 (https://download.01.org/0day-ci/archive/20250104/202501040409.SUV09R80-lkp@intel.com/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202501040409.SUV09R80-lkp@intel.com/
smatch warnings:
drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe'
vim +/dev_err_probe +134 drivers/pci/controller/pcie-rockchip.c
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 115 rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 116 if (IS_ERR(rockchip->aclk_rst)) {
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 117 if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 118 dev_err(dev, "missing aclk reset property in node\n");
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 119 return PTR_ERR(rockchip->aclk_rst);
e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 120 }
e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 121
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 122 if (rockchip->is_rc)
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 123 rockchip->perst_gpio = devm_gpiod_get_optional(dev, "ep",
840b7a5edf88fe drivers/pci/controller/pcie-rockchip.c Manivannan Sadhasivam 2024-04-16 124 GPIOD_OUT_LOW);
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 125 else
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 126 rockchip->perst_gpio = devm_gpiod_get_optional(dev, "reset",
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 127 GPIOD_IN);
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 128 if (IS_ERR(rockchip->perst_gpio))
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 129 return dev_err_probe(dev, PTR_ERR(rockchip->perst_gpio),
a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 130 "failed to get PERST# GPIO\n");
e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 131
fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 132 rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks);
fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 133 if (rockchip->num_clks < 0)
fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 @134 return dev_err_probe(dev, err, "failed to get clocks\n");
"err" is zero. It should be "rockchip->num_clks".
4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 135
964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 136 return 0;
4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 137 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [pci:controller/rockchip 1/3] drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe'
2025-01-06 11:39 [pci:controller/rockchip 1/3] drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe' Dan Carpenter
@ 2025-01-06 15:38 ` Anand Moon
0 siblings, 0 replies; 2+ messages in thread
From: Anand Moon @ 2025-01-06 15:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: oe-kbuild, lkp, oe-kbuild-all, linux-pci, Lorenzo Pieralisi,
Manivannan Sadhasivam
Hi Dan
On Mon, 6 Jan 2025 at 17:09, Dan Carpenter <dan.carpenter@linaro.org> wrote:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git controller/rockchip
> head: 8261bf695c47b98a2d8f63e04e2fc2e4a8c6b12b
> commit: fa0ce454cd4ee35703d4126c5b8e4a9a398cf198 [1/3] PCI: rockchip: Simplify clock handling by using clk_bulk*() function
> config: arm64-randconfig-r073-20250102 (https://download.01.org/0day-ci/archive/20250104/202501040409.SUV09R80-lkp@intel.com/config)
> compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> | Closes: https://lore.kernel.org/r/202501040409.SUV09R80-lkp@intel.com/
>
> smatch warnings:
> drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe'
>
> vim +/dev_err_probe +134 drivers/pci/controller/pcie-rockchip.c
>
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 115 rockchip->aclk_rst = devm_reset_control_get_exclusive(dev, "aclk");
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 116 if (IS_ERR(rockchip->aclk_rst)) {
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 117 if (PTR_ERR(rockchip->aclk_rst) != -EPROBE_DEFER)
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 118 dev_err(dev, "missing aclk reset property in node\n");
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 119 return PTR_ERR(rockchip->aclk_rst);
> e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 120 }
> e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 121
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 122 if (rockchip->is_rc)
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 123 rockchip->perst_gpio = devm_gpiod_get_optional(dev, "ep",
> 840b7a5edf88fe drivers/pci/controller/pcie-rockchip.c Manivannan Sadhasivam 2024-04-16 124 GPIOD_OUT_LOW);
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 125 else
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 126 rockchip->perst_gpio = devm_gpiod_get_optional(dev, "reset",
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 127 GPIOD_IN);
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 128 if (IS_ERR(rockchip->perst_gpio))
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 129 return dev_err_probe(dev, PTR_ERR(rockchip->perst_gpio),
> a7137cbf6bd53a drivers/pci/controller/pcie-rockchip.c Damien Le Moal 2024-10-17 130 "failed to get PERST# GPIO\n");
> e77f847df54c6b drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-09-03 131
> fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 132 rockchip->num_clks = devm_clk_bulk_get_all(dev, &rockchip->clks);
> fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 133 if (rockchip->num_clks < 0)
> fa0ce454cd4ee3 drivers/pci/controller/pcie-rockchip.c Anand Moon 2024-12-02 @134 return dev_err_probe(dev, err, "failed to get clocks\n");
>
>
> "err" is zero. It should be "rockchip->num_clks".
>
> 4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 135
> 964bac9455bee7 drivers/pci/host/pcie-rockchip.c Shawn Lin 2018-05-09 136 return 0;
> 4816c4c7b82b55 drivers/pci/host/pcie-rockchip.c Shawn Lin 2016-12-07 137 }
>
Thanks for the report I have submitted this fix for this.
[0] https://lore.kernel.org/linux-pci/20250106153041.55267-1-linux.amoon@gmail.com/
Thanks
-Anand
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-06 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 11:39 [pci:controller/rockchip 1/3] drivers/pci/controller/pcie-rockchip.c:134 rockchip_pcie_parse_dt() warn: passing zero to 'dev_err_probe' Dan Carpenter
2025-01-06 15:38 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox