From: Ziyue Zhang <quic_ziyuzhan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: <vkoul@kernel.org>, <kishon@kernel.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<dmitry.baryshkov@linaro.org>, <neil.armstrong@linaro.org>,
<abel.vesa@linaro.org>, <manivannan.sadhasivam@linaro.org>,
<lpieralisi@kernel.org>, <kw@linux.com>, <bhelgaas@google.com>,
<andersson@kernel.org>, <konradybcio@kernel.org>,
<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <quic_qianyu@quicinc.com>,
<quic_krichai@quicinc.com>, <quic_vbadigan@quicinc.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller
Date: Mon, 12 May 2025 16:16:00 +0800 [thread overview]
Message-ID: <e434124b-6975-4027-bb0d-3840fbd25a15@quicinc.com> (raw)
In-Reply-To: <20250507-astute-realistic-ferret-bcdfce@kuoka>
On 5/7/2025 1:17 PM, Krzysztof Kozlowski wrote:
> On Wed, May 07, 2025 at 11:15:56AM GMT, Ziyue Zhang wrote:
>> From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
>>
>> Add dedicated schema for the PCIe controllers found on QCS615.
>> Due to qcs615's clock-names do not match any of the existing
>> dt-bindings, a new compatible for qcs615 is needed.
> Other bindings for QCS615 were not finished, so I have doubts this is
> done as well. Send your bindings once you finish them.
>
> ...
>
>> +properties:
>> + compatible:
>> + const: qcom,qcs615-pcie
>> +
>> + reg:
>> + minItems: 6
>> + maxItems: 6
>> +
>> + reg-names:
>> + items:
>> + - const: parf # Qualcomm specific registers
>> + - const: dbi # DesignWare PCIe registers
>> + - const: elbi # External local bus interface registers
>> + - const: atu # ATU address space
>> + - const: config # PCIe configuration space
>> + - const: mhi # MHI registers
>> +
>> + clocks:
>> + minItems: 5
> Drop or use correct value - 6. I don't understand why this changed and
> nothing in changelog explains this.
>
> Best regards,
> Krzysztof
Hi Krzysztof
As discussed in qcs8300, gcc_aux_clk is recommended to be removed from PCIe PHY
device tree node, so I need to update the bindings.
BRs
Ziyue
next prev parent reply other threads:[~2025-05-12 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 3:15 [PATCH v4 0/5] pci: qcom: Add QCS615 PCIe support Ziyue Zhang
2025-05-07 3:15 ` [PATCH v4 1/5] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Update pcie phy bindings for QCS615 Ziyue Zhang
2025-05-07 5:12 ` Krzysztof Kozlowski
2025-05-07 3:15 ` [PATCH v4 2/5] dt-bindings: PCI: qcom: Document the QCS615 PCIe Controller Ziyue Zhang
2025-05-07 5:17 ` Krzysztof Kozlowski
2025-05-12 8:16 ` Ziyue Zhang [this message]
2025-05-12 9:26 ` Krzysztof Kozlowski
2025-05-07 3:15 ` [PATCH v4 3/5] arm64: dts: qcom: qcs615: enable pcie Ziyue Zhang
2025-05-08 14:47 ` Konrad Dybcio
2025-05-07 3:15 ` [PATCH v4 4/5] arm64: dts: qcom: qcs615-ride: Enable PCIe interface Ziyue Zhang
2025-05-07 3:15 ` [PATCH v4 5/5] PCI: qcom: Add support for QCS615 SoC Ziyue Zhang
2025-05-07 5:18 ` Krzysztof Kozlowski
2025-05-12 9:03 ` Ziyue Zhang
2025-05-07 15:41 ` [PATCH v4 0/5] pci: qcom: Add QCS615 PCIe support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e434124b-6975-4027-bb0d-3840fbd25a15@quicinc.com \
--to=quic_ziyuzhan@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_qianyu@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox