From: Markus Elfring <Markus.Elfring@web.de>
To: Ali Tariq <alitariq45892@gmail.com>,
linux-pci@vger.kernel.org, Kevin Xie <kevin.xie@starfivetech.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>
Subject: Re: [PATCH] PCI: starfive: Fix resource leaks on error paths in host_init()
Date: Wed, 15 Jul 2026 12:26:49 +0200 [thread overview]
Message-ID: <e9b0d5f8-baae-45bb-a8da-7ab88856dddb@web.de> (raw)
In-Reply-To: <20260714113029.326207-1-alitariq45892@gmail.com>
…
> Disable the PHY on the clk/reset failure path, and disable the
> clocks/resets and PHY, then return the error, if the regulator fails
> to enable.
…
Please avoid a bit of duplicate source code by using an additional label.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2-rc3#n526
Regards,
Markus
prev parent reply other threads:[~2026-07-15 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 11:30 [PATCH] PCI: starfive: Fix resource leaks on error paths in host_init() Ali Tariq
2026-07-14 11:53 ` sashiko-bot
2026-07-14 15:49 ` Ali Tariq
2026-07-15 10:26 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9b0d5f8-baae-45bb-a8da-7ab88856dddb@web.de \
--to=markus.elfring@web.de \
--cc=alitariq45892@gmail.com \
--cc=bhelgaas@google.com \
--cc=kevin.xie@starfivetech.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox