From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Christian König" <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, linux-pci@vger.kernel.org
Subject: Question about call to pci_assign_unassigned_bus_resources in amdgpu
Date: Mon, 24 Jun 2019 14:27:02 +1000 [thread overview]
Message-ID: <ed3d3e4e87b54fa4d0d8e68abeebb7be6711b82a.camel@kernel.crashing.org> (raw)
Hi Christian !
While cleaning up & consolidating resource management code accross
archs I stumbled upon this call to pci_assign_unassigned_bus_resources
in amdgpu:amdgpu_device_resize_fb_bar()
Why do you need this ? My understanding is that pci_resize_resource()
will already be calling pci_reassign_bridge_resources() on the parent
bridge which should have the same effect. Or am I missing something ?
I'd like to remove that call if possible...
Cheers,
Ben.
next reply other threads:[~2019-06-24 4:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 4:27 Benjamin Herrenschmidt [this message]
2019-06-24 8:42 ` Question about call to pci_assign_unassigned_bus_resources in amdgpu Koenig, Christian
2019-06-24 8:47 ` Benjamin Herrenschmidt
2019-06-24 8:56 ` Benjamin Herrenschmidt
2019-06-24 9:10 ` Koenig, Christian
2019-06-24 9:08 ` Koenig, Christian
2019-06-24 9:15 ` Benjamin Herrenschmidt
2019-06-24 9:42 ` Koenig, Christian
2019-06-24 10:27 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed3d3e4e87b54fa4d0d8e68abeebb7be6711b82a.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox