From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: Question about call to pci_assign_unassigned_bus_resources in amdgpu
Date: Mon, 24 Jun 2019 20:27:49 +1000 [thread overview]
Message-ID: <10cafe60fa12d3801d8645046be02771e8af7619.camel@kernel.crashing.org> (raw)
In-Reply-To: <0680ee65-5960-18b8-d7a2-eb87ec2056ef@amd.com>
On Mon, 2019-06-24 at 09:42 +0000, Koenig, Christian wrote:
>
> > Ok, Ill plumb it that way in my branch, I'll let you know when it's
> > worth testing. BTW. Which GPUs typically are affected ? I'm pretty
> > sure
> > my old R9 290 isn't :-) But I was thinking of upgrading so...
>
> Well in theory we have the functionality 10+ years now, but only
> activated it in all hardware versions recently.
>
> Polaris and Vega should definitely have it, older hardware most
> likely not.
>
> You can check the PCI capabilities and look for #15, if it's present
> then that should be supported.
Ok, well, we'll see if I decide to get myself a Navi when it comes out,
otherwise I'll rely on your testing :)
That said, I'm keen on having a discussion about our resource
assignment code at Plumbers with whoever can make it. The current
situation is rather horrible, it would be good to ensure at least that
we all understand and agree on what it's trying to do, what it's
actually doing, and what we want to do, which the more I stare at it
I'm reasonably sure are very different things depending on the
context...
Cheers,
Ben.
prev parent reply other threads:[~2019-06-24 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 4:27 Question about call to pci_assign_unassigned_bus_resources in amdgpu Benjamin Herrenschmidt
2019-06-24 8:42 ` Koenig, Christian
2019-06-24 8:47 ` Benjamin Herrenschmidt
2019-06-24 8:56 ` Benjamin Herrenschmidt
2019-06-24 9:10 ` Koenig, Christian
2019-06-24 9:08 ` Koenig, Christian
2019-06-24 9:15 ` Benjamin Herrenschmidt
2019-06-24 9:42 ` Koenig, Christian
2019-06-24 10:27 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10cafe60fa12d3801d8645046be02771e8af7619.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox