Re: [PATCH v4 1/2] PCI: Expose devm_pci_alloc_host_bridge_release()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing EXPORT_SYMBOL for devm_pci_alloc_host_bridge_release()
--

commit 3991d0ede1a56c908c8b226f72de68fc49a12993
Author: Bjorn Helgaas <helgaas@kernel.org>

PCI: Expose devm_pci_alloc_host_bridge_release()

This commit exposes devm_pci_alloc_host_bridge_release() so drivers can
avoid device tree parts by calling pci_alloc_host_bridge() directly and
adding the devm release function manually.

> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index ea6e77ecfd3f5..b4f781f423a35 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -699,7 +699,7 @@ struct pci_host_bridge *pci_alloc_host_bridge(size_t priv)
>  }
>  EXPORT_SYMBOL(pci_alloc_host_bridge);
>  
> -static void devm_pci_alloc_host_bridge_release(void *data)
> +void devm_pci_alloc_host_bridge_release(void *data)

[Severity: Low]
Does this function need an EXPORT_SYMBOL() or EXPORT_SYMBOL_GPL()
declaration?

Because devm_pci_alloc_host_bridge_release() is defined in the built-in
PCI subsystem but lacks an export, it cannot be linked by external
modules.

Compiling a host controller driver utilizing this devres action
(like drivers/pci/controller/pcie-iproc-bcma.c) as a loadable kernel module
will result in a modpost linker error for an undefined symbol.

>  {
>  	pci_free_host_bridge(data);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013220421.1588051-1-bhelgaas@google.com?part=1