Re: [PATCH v4 2/2] PCI: iproc: Use the EROM outbound window on BCMA

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pci: Module build failure due to unexported devm_pci_alloc_host_bridge_release
--

commit c2644cb699f7409a55741efcebcc09fcf3cf19bd
Author: Bjorn Helgaas <helgaas@kernel.org>

PCI: iproc: Use the EROM outbound window on BCMA

This commit updates the BCMA driver to request the memory window from the
EROM rather than relying on the device tree ranges. It directly uses
pci_alloc_host_bridge() to avoid requesting all DT resources and adds
validation to warn on window mismatches.

Link: https://patch.msgid.link/20260807160526.379-1-strst.gs@gmail.com
Link: https://patch.msgid.link/20260912043626.437-1-strst.gs@gmail.com

> diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c
> index 593418c2bc3aa..1e258cd8fed4f 100644
> --- a/drivers/pci/controller/pcie-iproc-bcma.c
> +++ b/drivers/pci/controller/pcie-iproc-bcma.c
[ ... ]
> @@ -38,10 +63,20 @@ static int iproc_bcma_pcie_probe(struct bcma_device *bdev)
>  	struct pci_host_bridge *bridge;
>  	int ret;
>  
> -	bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie));
> +	bridge = pci_alloc_host_bridge(sizeof(*pcie));
>  	if (!bridge)
>  		return -ENOMEM;
>  
> +	bridge->dev.parent = dev;
> +
> +	ret = devm_add_action_or_reset(dev, devm_pci_alloc_host_bridge_release,
> +				       bridge);

[Severity: Low]
Will this cause a build failure when the driver is configured as a
loadable module?

The symbol devm_pci_alloc_host_bridge_release is defined internally within
drivers/pci/probe.c but doesn't appear to be exported via EXPORT_SYMBOL()
or EXPORT_SYMBOL_GPL(). Does directly referencing it here in
iproc_bcma_pcie_probe() lead to an undefined reference error during
the linker stage?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013220421.1588051-1-bhelgaas@google.com?part=2