Linux PCI subsystem development
 help / color / mirror / Atom feed
* [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe
@ 2026-10-16 10:20 Alexander Gruhlke
  2026-10-16 10:25 ` sashiko-bot
  2026-10-16 17:15 ` Bjorn Helgaas
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Gruhlke @ 2026-10-16 10:20 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lukas Wunner, Alex Williamson, linux-pci, linux-kernel,
	regressions, Alexander Gruhlke

Like the 990 PRO, the Samsung 990 EVO Plus [144d:a80d] advertises
Immediate Readiness, and VFIO passthrough of it fails since commit
10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs").
Using a bus reset instead of FLR works around it, and the latest
firmware, 2B2QKXG7, is still affected.

Ignore Immediate Readiness on this device, too.

Fixes: 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs")
Link: https://bbs.archlinux.org/viewtopic.php?pid=2312085#p2312085
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Alexander Gruhlke <gruhlke@mailbox.org>
---
This adds the 990 EVO Plus to e6111fbf0c ("PCI: Ignore Immediate
Readiness on Samsung 990 PRO NVMe") in pci/for-linus, and could also
be folded into it.  I couldn't test it on this drive; the reporter
confirmed Status 0x0011 and that reset_method=bus fixes it.

 drivers/pci/quirks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 15f083b6b1..0d8c47a46c 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -5623,7 +5623,7 @@ static void quirk_no_flr_snet(struct pci_dev *dev)
 }
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLIDRUN, 0x1000, quirk_no_flr_snet);
 
-/* Samsung 990 PRO advertises Immediate Readiness, but isn't ready after FLR */
+/* Some Samsung SSDs advertise Immediate Readiness but aren't ready after FLR */
 static void quirk_no_imm_ready(struct pci_dev *dev)
 {
 	if (!dev->imm_ready)
@@ -5633,6 +5633,7 @@ static void quirk_no_imm_ready(struct pci_dev *dev)
 	dev->imm_ready = 0;
 }
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SAMSUNG, 0xa80c, quirk_no_imm_ready);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SAMSUNG, 0xa80d, quirk_no_imm_ready);
 
 static void quirk_no_ext_tags(struct pci_dev *pdev)
 {
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe
  2026-10-16 10:20 [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe Alexander Gruhlke
@ 2026-10-16 10:25 ` sashiko-bot
  2026-10-16 17:15 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-10-16 10:25 UTC (permalink / raw)
  To: Alexander Gruhlke; +Cc: linux-pci

> Like the 990 PRO, the Samsung 990 EVO Plus [144d:a80d] advertises
> Immediate Readiness, and VFIO passthrough of it fails since commit
> 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs").
> Using a bus reset instead of FLR works around it, and the latest
> firmware, 2B2QKXG7, is still affected.
> 
> Ignore Immediate Readiness on this device, too.
> 
> Fixes: 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs")
> Link: https://bbs.archlinux.org/viewtopic.php?pid=2312085#p2312085
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Alexander Gruhlke <gruhlke@mailbox.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016102042.641801-1-gruhlke@mailbox.org?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe
  2026-10-16 10:20 [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe Alexander Gruhlke
  2026-10-16 10:25 ` sashiko-bot
@ 2026-10-16 17:15 ` Bjorn Helgaas
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2026-10-16 17:15 UTC (permalink / raw)
  To: Alexander Gruhlke
  Cc: Bjorn Helgaas, Lukas Wunner, Alex Williamson, linux-pci,
	linux-kernel, regressions

On Fri, Oct 16, 2026 at 12:20:42PM +0200, Alexander Gruhlke wrote:
> Like the 990 PRO, the Samsung 990 EVO Plus [144d:a80d] advertises
> Immediate Readiness, and VFIO passthrough of it fails since commit
> 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs").
> Using a bus reset instead of FLR works around it, and the latest
> firmware, 2B2QKXG7, is still affected.
> 
> Ignore Immediate Readiness on this device, too.
> 
> Fixes: 10baa9b4df40 ("PCI: Drop unnecessary retries when restoring BARs")
> Link: https://bbs.archlinux.org/viewtopic.php?pid=2312085#p2312085
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Alexander Gruhlke <gruhlke@mailbox.org>

Squashed in, thanks!

> ---
> This adds the 990 EVO Plus to e6111fbf0c ("PCI: Ignore Immediate
> Readiness on Samsung 990 PRO NVMe") in pci/for-linus, and could also
> be folded into it.  I couldn't test it on this drive; the reporter
> confirmed Status 0x0011 and that reset_method=bus fixes it.
> 
>  drivers/pci/quirks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 15f083b6b1..0d8c47a46c 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -5623,7 +5623,7 @@ static void quirk_no_flr_snet(struct pci_dev *dev)
>  }
>  DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_SOLIDRUN, 0x1000, quirk_no_flr_snet);
>  
> -/* Samsung 990 PRO advertises Immediate Readiness, but isn't ready after FLR */
> +/* Some Samsung SSDs advertise Immediate Readiness but aren't ready after FLR */
>  static void quirk_no_imm_ready(struct pci_dev *dev)
>  {
>  	if (!dev->imm_ready)
> @@ -5633,6 +5633,7 @@ static void quirk_no_imm_ready(struct pci_dev *dev)
>  	dev->imm_ready = 0;
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SAMSUNG, 0xa80c, quirk_no_imm_ready);
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SAMSUNG, 0xa80d, quirk_no_imm_ready);
>  
>  static void quirk_no_ext_tags(struct pci_dev *pdev)
>  {
> -- 
> 2.56.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-16 17:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-16 10:20 [PATCH] PCI: Ignore Immediate Readiness on Samsung 990 EVO Plus NVMe Alexander Gruhlke
2026-10-16 10:25 ` sashiko-bot
2026-10-16 17:15 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox