* Re: [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency
2026-10-21 9:23 [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency Geert Uytterhoeven
@ 2026-10-21 9:27 ` sashiko-bot
2026-10-21 9:43 ` Bartosz Golaszewski
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-10-21 9:27 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-pci
> The Toshiba TC9563 GPIO controller is embedded in the Toshiba TC9563
> PCIe switch, and its auxiliary device is instantiated by the TC9563 PCI
> Power Control driver. Hence make GPIO_TC9563 depend on
> PCI_PWRCTRL_TC9563, to prevent asking the user about the GPIO driver
> when configuring a kernel without TC9563 PCI Power Control support.
>
> Drop the dependency of PCI_PWRCTRL_TC9563 on GPIO_TC9563, which
> represents the inverse and wrong relationship.
> Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS, as this is no longer
> guaranteed through GPIO_TC9563.
>
> Fixes: eea9a072221d97ab ("PCI/pwrctrl: tc9563: Add GPIO auxiliary device support")
> Fixes: 81ec9c22d06aea92 ("gpio: tc9563: Add support for the embedded GPIO controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/45484c37512a3102495d8b75b6e9f72a141ba42e.1792574560.git.geert+renesas@glider.be?part=1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency
2026-10-21 9:23 [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency Geert Uytterhoeven
2026-10-21 9:27 ` sashiko-bot
@ 2026-10-21 9:43 ` Bartosz Golaszewski
2026-10-21 9:49 ` Lorenzo Bianconi
2026-10-21 18:17 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-10-21 9:43 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-pci, linux-gpio, Manivannan Sadhasivam, Bjorn Helgaas,
Alex Elder, Daniel Thompson, Lorenzo Bianconi, Linus Walleij,
Bartosz Golaszewski
On Wed, 21 Oct 2026 11:23:52 +0200, Geert Uytterhoeven
<geert+renesas@glider.be> said:
> The Toshiba TC9563 GPIO controller is embedded in the Toshiba TC9563
> PCIe switch, and its auxiliary device is instantiated by the TC9563 PCI
> Power Control driver. Hence make GPIO_TC9563 depend on
> PCI_PWRCTRL_TC9563, to prevent asking the user about the GPIO driver
> when configuring a kernel without TC9563 PCI Power Control support.
>
> Drop the dependency of PCI_PWRCTRL_TC9563 on GPIO_TC9563, which
> represents the inverse and wrong relationship.
> Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS, as this is no longer
> guaranteed through GPIO_TC9563.
>
> Fixes: eea9a072221d97ab ("PCI/pwrctrl: tc9563: Add GPIO auxiliary device support")
> Fixes: 81ec9c22d06aea92 ("gpio: tc9563: Add support for the embedded GPIO controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency
2026-10-21 9:23 [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency Geert Uytterhoeven
2026-10-21 9:27 ` sashiko-bot
2026-10-21 9:43 ` Bartosz Golaszewski
@ 2026-10-21 9:49 ` Lorenzo Bianconi
2026-10-21 18:17 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Bianconi @ 2026-10-21 9:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Manivannan Sadhasivam, Bjorn Helgaas, Alex Elder, Daniel Thompson,
Linus Walleij, Bartosz Golaszewski, linux-pci, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]
> The Toshiba TC9563 GPIO controller is embedded in the Toshiba TC9563
> PCIe switch, and its auxiliary device is instantiated by the TC9563 PCI
> Power Control driver. Hence make GPIO_TC9563 depend on
> PCI_PWRCTRL_TC9563, to prevent asking the user about the GPIO driver
> when configuring a kernel without TC9563 PCI Power Control support.
>
> Drop the dependency of PCI_PWRCTRL_TC9563 on GPIO_TC9563, which
> represents the inverse and wrong relationship.
> Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS, as this is no longer
> guaranteed through GPIO_TC9563.
>
> Fixes: eea9a072221d97ab ("PCI/pwrctrl: tc9563: Add GPIO auxiliary device support")
> Fixes: 81ec9c22d06aea92 ("gpio: tc9563: Add support for the embedded GPIO controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS.
> ---
> drivers/gpio/Kconfig | 1 +
> drivers/pci/pwrctrl/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5d3f076c539b3a64..c5556b1638b8c113 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1893,6 +1893,7 @@ endmenu
>
> config GPIO_TC9563
> tristate "Toshiba TC9563 GPIO support"
> + depends on PCI_PWRCTRL_TC9563 || COMPILE_TEST
> default m if ARCH_QCOM
> select AUXILIARY_BUS
> select GPIO_REGMAP
> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> index 38aab596aa04b8b1..a2fc2a359702e861 100644
> --- a/drivers/pci/pwrctrl/Kconfig
> +++ b/drivers/pci/pwrctrl/Kconfig
> @@ -29,7 +29,7 @@ config PCI_PWRCTRL_TC9563
> select PCI_PWRCTRL
> default m if ARCH_QCOM
> depends on I2C
> - depends on GPIO_TC9563
> + select AUXILIARY_BUS
> select REGMAP_I2C
> help
> Say Y here to enable the PCI Power Control driver of TC9563 PCIe
> --
> 2.43.0
>
Acked-by: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency
2026-10-21 9:23 [PATCH v2] PCI/pwrctrl/gpio: Correct GPIO_TC9563 / PCI_PWRCTRL_TC9563 dependency Geert Uytterhoeven
` (2 preceding siblings ...)
2026-10-21 9:49 ` Lorenzo Bianconi
@ 2026-10-21 18:17 ` Bjorn Helgaas
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2026-10-21 18:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Manivannan Sadhasivam, Bjorn Helgaas, Alex Elder, Daniel Thompson,
Lorenzo Bianconi, Linus Walleij, Bartosz Golaszewski, linux-pci,
linux-gpio
On Wed, Oct 21, 2026 at 11:23:52AM +0200, Geert Uytterhoeven wrote:
> The Toshiba TC9563 GPIO controller is embedded in the Toshiba TC9563
> PCIe switch, and its auxiliary device is instantiated by the TC9563 PCI
> Power Control driver. Hence make GPIO_TC9563 depend on
> PCI_PWRCTRL_TC9563, to prevent asking the user about the GPIO driver
> when configuring a kernel without TC9563 PCI Power Control support.
>
> Drop the dependency of PCI_PWRCTRL_TC9563 on GPIO_TC9563, which
> represents the inverse and wrong relationship.
> Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS, as this is no longer
> guaranteed through GPIO_TC9563.
>
> Fixes: eea9a072221d97ab ("PCI/pwrctrl: tc9563: Add GPIO auxiliary device support")
> Fixes: 81ec9c22d06aea92 ("gpio: tc9563: Add support for the embedded GPIO controller")
These are still pending in pci/pwrctrl, so I squashed these fixes into
those commits for v7.4.
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Let PCI_PWRCTRL_TC9563 select AUXILIARY_BUS.
> ---
> drivers/gpio/Kconfig | 1 +
> drivers/pci/pwrctrl/Kconfig | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5d3f076c539b3a64..c5556b1638b8c113 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1893,6 +1893,7 @@ endmenu
>
> config GPIO_TC9563
> tristate "Toshiba TC9563 GPIO support"
> + depends on PCI_PWRCTRL_TC9563 || COMPILE_TEST
> default m if ARCH_QCOM
> select AUXILIARY_BUS
> select GPIO_REGMAP
> diff --git a/drivers/pci/pwrctrl/Kconfig b/drivers/pci/pwrctrl/Kconfig
> index 38aab596aa04b8b1..a2fc2a359702e861 100644
> --- a/drivers/pci/pwrctrl/Kconfig
> +++ b/drivers/pci/pwrctrl/Kconfig
> @@ -29,7 +29,7 @@ config PCI_PWRCTRL_TC9563
> select PCI_PWRCTRL
> default m if ARCH_QCOM
> depends on I2C
> - depends on GPIO_TC9563
> + select AUXILIARY_BUS
> select REGMAP_I2C
> help
> Say Y here to enable the PCI Power Control driver of TC9563 PCIe
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread