[PATCH v2] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[PATCH v2] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[Marek Vasut]

The R-Car Gen5 SoC PCIe4 controller does not have dedicated sft_ce IRQ.
Make that interrupt conditionally available only on R-Car Gen4 SoC PCIe
controller.

The R-Car Gen5 SoC PCIe4 controller does have dedicated AER interrupt,
include it from the beginning. R-Car Gen4 SoC PCIe controller also has
an AER interrupt, but to retain binding backward compatibility, this
interrupt is kept optional and added in a separate patchset.

Fixes: 5b555a496160 ("dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible")
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: "Krzysztof Wilczyński" <kwilczynski@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Koichiro Den <den@valinux.co.jp>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org
---
NOTE: Gen4 AER is added in https://lore.kernel.org/all/20260928165230.3397664-1-den@valinux.co.jp/
---
V2: Keep interrupt-names with maxItems: 4
---
 .../bindings/pci/rcar-gen4-pci-host.yaml      | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
index 362c43a1a15d0..a79780185d116 100644
--- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
@@ -29,11 +29,7 @@ properties:
     maxItems: 4
 
   interrupt-names:
-    items:
-      - const: msi
-      - const: dma
-      - const: sft_ce
-      - const: app
+    maxItems: 4
 
   clocks:
     maxItems: 2
@@ -98,6 +94,13 @@ allOf:
             - const: app
             - const: phy
             - const: config
+
+        interrupt-names:
+          items:
+            - const: msi
+            - const: dma
+            - const: sft_ce
+            - const: app
   - if:
       properties:
         compatible:
@@ -117,6 +120,13 @@ allOf:
             - const: app
             - const: config
 
+        interrupt-names:
+          items:
+            - const: msi
+            - const: dma
+            - const: app
+            - const: aer
+
 unevaluatedProperties: false
 
 examples:
-- 
2.53.0

Re: [PATCH v2] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[sashiko-bot]

> The R-Car Gen5 SoC PCIe4 controller does not have dedicated sft_ce IRQ.
> Make that interrupt conditionally available only on R-Car Gen4 SoC PCIe
> controller.
> 
> The R-Car Gen5 SoC PCIe4 controller does have dedicated AER interrupt,
> include it from the beginning. R-Car Gen4 SoC PCIe controller also has
> an AER interrupt, but to retain binding backward compatibility, this
> interrupt is kept optional and added in a separate patchset.
> 
> Fixes: 5b555a496160 ("dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026224447.606715-1-marek.vasut+renesas@mailbox.org?part=1

Re: [PATCH v2] dt-bindings: PCI: rcar-gen4-pci-host: Replace sft_ce IRQ with AER IRQ on R-Car Gen5

[Krzysztof Kozlowski]

On Mon, Oct 26, 2026 at 11:44:18PM +0100, Marek Vasut wrote:
> The R-Car Gen5 SoC PCIe4 controller does not have dedicated sft_ce IRQ.
> Make that interrupt conditionally available only on R-Car Gen4 SoC PCIe
> controller.
> 
> The R-Car Gen5 SoC PCIe4 controller does have dedicated AER interrupt,
> include it from the beginning. R-Car Gen4 SoC PCIe controller also has
> an AER interrupt, but to retain binding backward compatibility, this
> interrupt is kept optional and added in a separate patchset.
> 
> Fixes: 5b555a496160 ("dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible")
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof