[PATCH 1/1] PCI: endpoint: pci-epf-test: use dmaengine_desc_set_callback()

[PATCH 1/1] PCI: endpoint: pci-epf-test: use dmaengine_desc_set_callback()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Replace open-coded assignments to callback and callback_param fields
of struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.

No functional change intended. Prepare to make struct
dma_async_tx_descriptor private to the DMA engine.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/pci/endpoint/functions/pci-epf-test.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index d4905aa8e4c01..3ec7e1a05b2b9 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -197,8 +197,7 @@ static int pci_epf_test_data_transfer(struct pci_epf_test *epf_test,
 
 	reinit_completion(&epf_test->transfer_complete);
 	epf_test->transfer_chan = chan;
-	tx->callback = pci_epf_test_dma_callback;
-	tx->callback_param = epf_test;
+	dmaengine_desc_set_callback(tx, pci_epf_test_dma_callback, NULL, epf_test);
 	epf_test->transfer_cookie = dmaengine_submit(tx);
 
 	ret = dma_submit_error(epf_test->transfer_cookie);
-- 
2.43.0

Re: [PATCH 1/1] PCI: endpoint: pci-epf-test: use dmaengine_desc_set_callback()

[sashiko-bot]

> From: Frank Li <Frank.Li@nxp.com>
> 
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper.
> 
> No functional change intended. Prepare to make struct
> dma_async_tx_descriptor private to the DMA engine.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102192722.4051764-1-Frank.Li@oss.nxp.com?part=1