[PATCH 1/1] PCI: replace chan->device->dev with dmaengine_get_provider_device()

[PATCH 1/1] PCI: replace chan->device->dev with dmaengine_get_provider_device()

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

Use the dmaengine_get_provider_device() API instead of directly
accessing chan->device->dev to get the DMA provider device.

No functional change. Prepare make to struct dma_device private to the DMA
engine.

Assisted-by: LLM
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/pci/endpoint/functions/pci-epf-mhi.c  | 2 +-
 drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
index 78f1fb1a6b0c7..5677fcbfe44f7 100644
--- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
+++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
@@ -646,7 +646,7 @@ static bool pci_epf_mhi_filter(struct dma_chan *chan, void *node)
 	memset(&caps, 0, sizeof(caps));
 	dma_get_slave_caps(chan, &caps);
 
-	return chan->device->dev == filter->dev && filter->dma_mask &
+	return dmaengine_get_provider_device(chan) == filter->dev && filter->dma_mask &
 					caps.directions;
 }
 
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
index d4905aa8e4c01..fd63e423c4726 100644
--- a/drivers/pci/endpoint/functions/pci-epf-test.c
+++ b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -238,7 +238,7 @@ static bool epf_dma_filter_fn(struct dma_chan *chan, void *node)
 	memset(&caps, 0, sizeof(caps));
 	dma_get_slave_caps(chan, &caps);
 
-	return chan->device->dev == filter->dev
+	return dmaengine_get_provider_device(chan) == filter->dev
 		&& (filter->dma_mask & caps.directions);
 }
 
-- 
2.43.0

Re: [PATCH 1/1] PCI: replace chan->device->dev with dmaengine_get_provider_device()

[sashiko-bot]

> From: Frank Li <Frank.Li@nxp.com>
> 
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.
> 
> Assisted-by: LLM
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103212924.1780217-1-Frank.Li@oss.nxp.com?part=1

Re: [PATCH 1/1] PCI: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Tue, Nov 03, 2026 at 04:29:20PM -0500, Frank.Li@oss.nxp.com wrote:
> 
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

...

>  Assisted-by: LLM

It's an obsolete tag. Please, replace it in a free-form explanation how AI was
used in the comment block, below '---' line.

> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

...

> static bool pci_epf_mhi_filter(struct dma_chan *chan, void *node)

>  	memset(&caps, 0, sizeof(caps));
>  	dma_get_slave_caps(chan, &caps);
>  
> -	return chan->device->dev == filter->dev && filter->dma_mask &
> +	return dmaengine_get_provider_device(chan) == filter->dev && filter->dma_mask &
>  					caps.directions;

While at it, fix indentation:

	return dmaengine_get_provider_device(chan) == filter->dev &&
	       (filter->dma_mask & caps.directions);

...

> static bool epf_dma_filter_fn(struct dma_chan *chan, void *node)

>  	memset(&caps, 0, sizeof(caps));
>  	dma_get_slave_caps(chan, &caps);
>  
> -	return chan->device->dev == filter->dev
> +	return dmaengine_get_provider_device(chan) == filter->dev
>  		&& (filter->dma_mask & caps.directions);

Ditto.

	return dmaengine_get_provider_device(chan) == filter->dev &&
	       (filter->dma_mask & caps.directions);

...

Looking more at it, you probably want to deduplicate this code at some point.


-- 
With Best Regards,
Andy Shevchenko