Re: [PATCH] PCI/DPC: Increase recovery timeout to 60 seconds

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] PCI/DPC: undeclared PCIE_RESET_READY_POLL_MS in
  pci_dpc_recovered()
--

commit 9107bdc3c03dade9f834df49cdbc6c47d0a15a44
Author: Ziyou Wang (Lenovo) <ziyou.dev@foxmail.com>

PCI/DPC: Increase recovery timeout to 60 seconds

This commit increases the DPC recovery wait timeout in pci_dpc_recovered()
from 4 seconds to PCIE_RESET_READY_POLL_MS (60 seconds).

> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index 2b779bd1d861b..df1c469fa24cd 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -116,12 +116,13 @@ bool pci_dpc_recovered(struct pci_dev *pdev)
>  		return false;
>  
>  	/*
> -	 * Need a timeout in case DPC never completes due to failure of
> -	 * dpc_wait_rp_inactive().  The spec doesn't mandate a time limit,
> -	 * but reports indicate that DPC completes within 4 seconds.
> +	 * Wait for DPC recovery completion.  Use PCIE_RESET_READY_POLL_MS
> +	 * (60s) to match pci_dev_wait() timeout.  Some devices need >5 seconds
> +	 * to recover after DPC containment.  The 4 second timeout is too short.
>  	 */
> -	wait_event_timeout(dpc_completed_waitqueue, dpc_completed(pdev),
> -			   msecs_to_jiffies(4000));
> +	wait_event_timeout(dpc_completed_waitqueue,
> +			   dpc_completed(pdev),
> +			   msecs_to_jiffies(PCIE_RESET_READY_POLL_MS));

[Severity: High]
Does this fail to build when CONFIG_PCIE_DPC and CONFIG_HOTPLUG_PCI_PCIE
are enabled?  PCIE_RESET_READY_POLL_MS is defined locally in
drivers/pci/pci.c rather than in drivers/pci/pci.h, so it is undeclared in
drivers/pci/pcie/dpc.c.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_0EA784F33CA15095806009C26E9DD624B809@qq.com?part=1