[PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[hongxing.zhu]

From: Richard Zhu <hongxing.zhu@nxp.com>

Add support L1SS support for the i.MX6 PCIe controller when the
`supports_clkreq` flag is set.

Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 drivers/pci/controller/dwc/pci-imx6.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 83fbd998551d0..4eee02e135656 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1501,6 +1501,9 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp)
 
 	imx_setup_phy_mpll(imx_pcie);
 
+	if (imx_pcie->supports_clkreq)
+		pci->l1ss_support = true;
+
 	return 0;
 
 err_phy_off:
-- 
2.34.1

Re: [PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[sashiko-bot]

> From: Richard Zhu <hongxing.zhu@nxp.com>
> 
> Add support L1SS support for the i.MX6 PCIe controller when the
> `supports_clkreq` flag is set.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106090342.2601665-1-hongxing.zhu@oss.nxp.com?part=1

Re: [PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[Fabio Estevam]

On Fri, Nov 6, 2026 at 6:00 AM <hongxing.zhu@oss.nxp.com> wrote:
>
> From: Richard Zhu <hongxing.zhu@nxp.com>
>
> Add support L1SS support for the i.MX6 PCIe controller when the
> `supports_clkreq` flag is set.

Please explain why this is needed.

Also, does it need a Fixes tag?

RE: [PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[Hongxing Zhu (OSS)]

> -----Original Message-----
> From: Fabio Estevam <festevam@gmail.com>
> Sent: Friday, November 6, 2026 8:11 PM
> To: Hongxing Zhu (OSS) <hongxing.zhu@oss.nxp.com>
> Cc: Frank Li (OSS) <frank.li@oss.nxp.com>; jingoohan1@gmail.com;
> l.stach@pengutronix.de; lpieralisi@kernel.org; kwilczynski@kernel.org;
> mani@kernel.org; robh@kernel.org; bhelgaas@google.com;
> s.hauer@pengutronix.de; kernel@pengutronix.de; linux-pci@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev; linux-
> kernel@vger.kernel.org; Hongxing Zhu <hongxing.zhu@nxp.com>
> Subject: Re: [PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq
> is true
> 
> On Fri, Nov 6, 2026 at 6:00 AM <hongxing.zhu@oss.nxp.com> wrote:
> >
> > From: Richard Zhu <hongxing.zhu@nxp.com>
> >
> > Add support L1SS support for the i.MX6 PCIe controller when the
> > `supports_clkreq` flag is set.
> 
> Please explain why this is needed.
> 
> Also, does it need a Fixes tag? 
Hi Fabio:
Thanks for your comments.
The change is intended to enable L1SS for the i.MX6 PCIe controller when the
supports_clkreq flag is set.

The commit a00bba406b5a ("PCI: dwc: Advertise L1 PM Substates only if driver
requests it") introduced a mechanism that clears the L1SS capabilities by
default. However, the i.MX PCIe controller inherently supports L1SS, as
indicated by the settings in the L1SS capabilities register.

By setting dw_pcie.l1ss_support to true when supports_clkreq is true, we
ensure that the i.MX6 PCIe controller can properly utilize L1SS, allowing the
PCIe endpoint to enter low-power states efficiently when the link is not in
use. This optimization is crucial for power management and energy efficiency
on i.MX6-based platforms.

A Fixes tag is not required for this change because it is not addressing a
specific bug or issue tracked in a previous commit. Instead, this change is
enhancing the existing functionality to better align with the i.MX6 PCIe
controller’s capabilities.

How about to update the commit as below?
Enable L1SS for the i.MX6 PCIe controller when the `supports_clkreq` flag is
set. This ensures that the PCIe endpoint can enter low-power states
efficiently when the link is not in use.

The commit a00bba406b5a ("PCI: dwc: Advertise L1 PM Substates only if
driver requests it") clears L1SS capabilities by default. However, the
i.MX PCIe controller supports L1SS as indicated by the settings in the L1SS
capabilities register. By setting `dw_pcie.l1ss_support` to true when
`supports_clkreq` is true, enable proper utilization of L1SS for i.MX6 PCIe
configurations.

Best Regards
Richard Zhu

Re: [PATCH v1] PCI: imx6: Enable L1SS support when supports_clkreq is true

[Fabio Estevam]

Hi Richard,

On Sun, Nov 8, 2026 at 11:00 PM Hongxing Zhu (OSS)
<hongxing.zhu@oss.nxp.com> wrote:

> How about to update the commit as below?

Yes, it looks much better. Please send a v2 with this explanation.

Thanks