Re: [PATCH v5 09/14] PCI: Place resources to either edge of the window

[sashiko-bot@kernel.org]

> PCI resource assignment phase is based on a greedy algorithm. The
> resources are assigned in descending order of required alignment.
> Because the PCI BARs are power-of-two sized resources, it mostly works
> (bridge windows and VF BARs are composite resources that might not
> necessarily have power-of-two size but internally they are still
> composed of BARs).
> 
> The resource assignment prior to the commit 9036bd0efcb6 ("PCI: Align
> head space better") placed resources towards the left edge of the
> window. Tha commit altered assignment for resources whose size is not a
> perfect multiple of the required alignment by moving the remainder
> before the left edge of the window if possible.
> 
> The behavior after the commit 9036bd0efcb6 ("PCI: Align head space
> better") may result in problems when a bridge window consists of one
> [ ... ]
> Tested-by: Alexey Fomenko <alexey.fomenko@intel.com>
> Reported-by: Eric Auger <eric.auger@redhat.com>
> Tested-by: Eric Auger <eric.auger@redhat.com>
> Tested-by: Nikolas Joshua Britton <nbritton@exabit.io>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106134341.39493-1-ilpo.jarvinen@linux.intel.com?part=9