Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v5 13/14] PCI: Fix composite resource sizing
Date: Fri, 06 Nov 2026 15:26:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-201690@kernel.org> (raw)
In-Reply-To: <20261106134341.39493-14-ilpo.jarvinen@linux.intel.com>

> The bridge window sizing algorithm aims to pack child resources back to
> back. With composite child resources whose sizes are not a power of two,
> back-to-back placement may not be possible. The non-aligning remainder
> placement is limited because it must be adjacent to the rest of the
> composite resource.
> 
> Add bridge window gap size calculation.
> 
> When there are only two resources and at least one of them is
> composite, the gap end address aligns to meet the smaller of the two
> alignment requirements. If there is only one composite resource, the
> smaller alignment may be that of the composite resource.
> 
> Other combinations fall back to filling each resource's align sized
> blocks fully. Sometimes, smaller size may be possible but due to how
> sizing and assignment are made in different phases, it is not always
> possible to predict where each resource is assigned. Thus, the sizing
> has to play it safe.
> 
> Fixes: 9036bd0efcb6 ("PCI: Align head space better")
> Reported-by: Bjorn Helgaas <bhelgaas@google.com>
> Reported-by: Nikolas Joshua Britton <nbritton@exabit.io>
> Link: https://lore.kernel.org/linux-pci/20260903063124.9316-1-nbritton@exabit.io/
> Reported-by: Maciej Grochowski <Maciej.Grochowski@sony.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106134341.39493-1-ilpo.jarvinen@linux.intel.com?part=13


  reply	other threads:[~2026-11-06 15:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 13:43 [PATCH v5 00/14] PCI: Resource placement algorithm fixes Ilpo Järvinen
2026-11-06 13:43 ` [PATCH v5 01/14] resource: Mark free space assigned Ilpo Järvinen
2026-11-06 13:52   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 02/14] parisc/PCI: Clean up resource debug print & use dynamic debug Ilpo Järvinen
2026-11-06 13:55   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 03/14] PCI: Don't size or assign disabled BARs Ilpo Järvinen
2026-11-06 14:00   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 04/14] PCI: Use __ffs64() for resource_size_t typed align Ilpo Järvinen
2026-11-06 14:10   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 05/14] PCI: Prevent zero align from reaching __ffs64() Ilpo Järvinen
2026-11-06 14:16   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 06/14] linux/log2.h: Add 64-bit roundup/down_pow_of_two_u64() variants Ilpo Järvinen
2026-11-06 14:19   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 07/14] PCI: Derive aligns[] array size in a define Ilpo Järvinen
2026-11-06 14:22   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 08/14] PCI: Honor alignment overrides Ilpo Järvinen
2026-11-06 14:38   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 09/14] PCI: Place resources to either edge of the window Ilpo Järvinen
2026-11-06 14:55   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 10/14] PCI: Separate align/raw size calculation from pbus_size_mem() Ilpo Järvinen
2026-11-06 14:57   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 11/14] PCI: Calculate bridge window with optional sizes from scratch Ilpo Järvinen
2026-11-06 15:06   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 12/14] PCI: Move size/align calculation fully into __pbus_size_mem() Ilpo Järvinen
2026-11-06 15:10   ` sashiko-bot
2026-11-06 13:43 ` [PATCH v5 13/14] PCI: Fix composite resource sizing Ilpo Järvinen
2026-11-06 15:26   ` sashiko-bot [this message]
2026-11-06 13:43 ` [PATCH v5 14/14] PCI: Add debug printing to window sizing Ilpo Järvinen
2026-11-06 15:37   ` sashiko-bot
2026-11-06 15:26 ` [PATCH v5 00/14] PCI: Resource placement algorithm fixes Nikolas Joshua Britton
2026-11-06 16:43   ` Ilpo Järvinen
2026-11-08  1:51 ` Doug Calobrisi
2026-11-09 23:27 ` Bjorn Helgaas
2026-11-10  9:47   ` Ilpo Järvinen
2026-11-10 20:06     ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-201690@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox