From: sashiko-bot@kernel.org
To: "Simon Song" <xinmengs@nvidia.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 08/11] rust: pci: add SR-IOV enable and disable tokens
Date: Wed, 11 Nov 2026 23:55:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-209868@kernel.org> (raw)
In-Reply-To: <20261111223337.508989-9-xinmengs@nvidia.com>
> From: Zhi Wang <zhiw@nvidia.com>
>
> Enabling VFs can succeed before the driver's remaining setup fails.
> Use a callback-scoped token to return an enabled guard that disables
> SR-IOV when dropped, rolling back those VFs on a later error.
>
> Add SriovEnable, SriovEnabled and SriovDisable for the split callbacks
> introduced later in this series. Tie each token to its PF and callback
> lifetime, and limit the enabled count to the user's request. The PCI
> adapter disarms the guard when accepting a successful enable callback.
>
> Require a VfRegistration to own final VF teardown after that handoff.
> Drivers that do not share data with VFs can register (). A disable
> token permits explicit shutdown without forcing it on a rejected
> request.
>
> Suggested-by: Danilo Krummrich <dakr@kernel.org>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
> Signed-off-by: Simon Song <xinmengs@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111223337.508989-1-xinmengs@nvidia.com?part=8
next prev parent reply other threads:[~2026-11-11 23:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:33 [PATCH v6 00/11] Add Rust PCI SR-IOV support Simon Song
2026-11-11 22:33 ` [PATCH v6 01/11] rust: pci: add internal SR-IOV enable and disable helpers Simon Song
2026-11-11 23:53 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 02/11] rust: pci: add vtable attribute to pci::Driver trait Simon Song
2026-11-11 23:54 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 03/11] rust: pci: add is_virtfn(), to check for VFs Simon Song
2026-11-11 23:56 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 04/11] rust: pci: add num_vf(), to return number of VFs Simon Song
2026-11-11 23:53 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 05/11] rust: device: clarify the drvdata_borrow() safety requirement Simon Song
2026-11-11 23:54 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 06/11] rust: pci: drop driver data before remove returns Simon Song
2026-11-11 23:56 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 07/11] rust: pci: add typed SR-IOV PF registration data Simon Song
2026-11-12 0:04 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 08/11] rust: pci: add SR-IOV enable and disable tokens Simon Song
2026-11-11 23:55 ` sashiko-bot [this message]
2026-11-11 22:33 ` [PATCH v6 09/11] rust: pci: add SriovEnable::enable_all(), to enable all requested VFs Simon Song
2026-11-11 23:55 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 10/11] rust: pci: add SR-IOV enable and disable callbacks Simon Song
2026-11-12 0:01 ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 11/11] samples: rust: add a Rust SR-IOV PF and VF driver sample Simon Song
2026-11-12 0:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209868@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xinmengs@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox