Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Simon Song" <xinmengs@nvidia.com>, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 11/11] samples: rust: add a Rust SR-IOV PF and VF driver sample
Date: Thu, 12 Nov 2026 00:01:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-209873@kernel.org> (raw)
In-Reply-To: <20261111223337.508989-12-xinmengs@nvidia.com>

> From: Peter Colberg <peter@colberg.org>
> 
> Add a sample module with a PF and a VF driver that demonstrates SR-IOV
> using QEMU's 82576 (igb) emulation.
> 
> The PF publishes a pinned API object in its private data and provides a
> submit_request() helper. The VF calls this helper with its Bound device
> borrow. The helper performs the typed registration lookup, so the VF
> driver does not use the API object or its lifetime encoding directly.
> 
> Keep the PF and VF drivers in separate files, but build them into a
> single module that registers both drivers. Separate modules would need
> cross-crate Rust symbol exports, which can be added once the build
> system supports them.
> 
> Unbinding the PF disables SR-IOV and removes its VFs before releasing
> the registered data.
> 
> Link: https://www.qemu.org/docs/master/system/devices/igb.html
> Signed-off-by: Peter Colberg <peter@colberg.org>
> Co-developed-by: Zhi Wang <zhiw@nvidia.com>
> Signed-off-by: Zhi Wang <zhiw@nvidia.com>
> Co-developed-by: Simon Song <xinmengs@nvidia.com>
> Signed-off-by: Simon Song <xinmengs@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111223337.508989-1-xinmengs@nvidia.com?part=11


      reply	other threads:[~2026-11-12  0:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 22:33 [PATCH v6 00/11] Add Rust PCI SR-IOV support Simon Song
2026-11-11 22:33 ` [PATCH v6 01/11] rust: pci: add internal SR-IOV enable and disable helpers Simon Song
2026-11-11 23:53   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 02/11] rust: pci: add vtable attribute to pci::Driver trait Simon Song
2026-11-11 23:54   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 03/11] rust: pci: add is_virtfn(), to check for VFs Simon Song
2026-11-11 23:56   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 04/11] rust: pci: add num_vf(), to return number of VFs Simon Song
2026-11-11 23:53   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 05/11] rust: device: clarify the drvdata_borrow() safety requirement Simon Song
2026-11-11 23:54   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 06/11] rust: pci: drop driver data before remove returns Simon Song
2026-11-11 23:56   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 07/11] rust: pci: add typed SR-IOV PF registration data Simon Song
2026-11-12  0:04   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 08/11] rust: pci: add SR-IOV enable and disable tokens Simon Song
2026-11-11 23:55   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 09/11] rust: pci: add SriovEnable::enable_all(), to enable all requested VFs Simon Song
2026-11-11 23:55   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 10/11] rust: pci: add SR-IOV enable and disable callbacks Simon Song
2026-11-12  0:01   ` sashiko-bot
2026-11-11 22:33 ` [PATCH v6 11/11] samples: rust: add a Rust SR-IOV PF and VF driver sample Simon Song
2026-11-12  0:01   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-209873@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xinmengs@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox