Linux PCI subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aviv Bakal" <avivb@amazon.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2 3/3] PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot
Date: Mon, 16 Nov 2026 17:04:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-217406@kernel.org> (raw)
In-Reply-To: <20261116165110.2773301-4-avivb@amazon.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI/PM: missing Fixes trailer for commit d4c79b63d82d in commit
  message
--

commit 70281f514dfa84e338f2e7558fdf02d6a96db4d6
Author: Aviv Bakal <avivb@amazon.com>

> PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot
>
> On runtime suspend pciehp masks the hotplug interrupt and relies on
> PME to resume the port on a slot event. pci_bridge_d3_possible() does
> not check whether the port can signal PME from D3hot, so a port that
> cannot is not resumed by slot events.
>
> Return false from pci_bridge_d3_possible() for such native hotplug
> ports. pci_pm_init() computes bridge_d3 before it reads PME_Support,
> so move that assignment after dev->pme_support is set.
>
> Co-developed-by: Zeev Zilberman <zeev@amazon.com>
> Signed-off-by: Zeev Zilberman <zeev@amazon.com>
> Signed-off-by: Aviv Bakal <avivb@amazon.com>

[Severity: Low]
This fixes a regression on non-x86 native hotplug ports that cannot
signal PME from D3hot, which were allowed into D3 by commit d4c79b63d82d
("PCI: Allow D3 for native hotplug-capable Root Ports on non-x86
platforms").  Should this include:

  Fixes: d4c79b63d82d ("PCI: Allow D3 for native hotplug-capable Root Ports on non-x86 platforms")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116165110.2773301-1-avivb@amazon.com?part=3

      reply	other threads:[~2026-11-16 17:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:51 [PATCH v2 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3 Aviv Bakal
2026-11-16 16:51 ` [PATCH v2 1/3] PCI/PM: Honor PCI_DEV_FLAGS_NO_D3 in pci_bridge_d3_possible() Aviv Bakal
2026-11-16 16:51 ` [PATCH v2 2/3] PCI: Avoid runtime D3 on Amazon PCIe switch ports Aviv Bakal
2026-11-16 16:58   ` sashiko-bot
2026-11-16 16:51 ` [PATCH v2 3/3] PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot Aviv Bakal
2026-11-16 17:04   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217406@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=avivb@amazon.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox