Re: [PATCH] perf report: Support caller callchain order when using DWARF unwinder.

[Milian Wolff <milian.wolff@kdab.com>]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

On Tuesday, November 3, 2015 8:37:11 AM CET Jiri Olsa wrote:
> On Fri, Oct 09, 2015 at 07:29:34PM +0200, Milian Wolff wrote:
> 
> SNIP
> 
> > > ;-)
> > > 
> > > any chance this could be done also for util/unwind-libdw.c ?
> > 
> > That patch looks much better than mine. I'll try it out later next week
> > and
> > will also have a look at util/unwind-libdw.c. Question: How can I test the
> > behavior of the latter? Do I need to uninstall libunwind, or can I change
> > the unwinder at runtime somehow (env var?).
> 
> It's either libunwind or libdw compiled in, so I'd suggest
> generic test (see below) and compile with make variables
> NO_LIBUNWIND=1 or NO_LIBDW_DWARF_UNWIND=1 to get desired
> unwinder compiled in
> 
> > Also, are there unit tests for this behavior somewhere?
> 
> please check tests/dwarf-unwind.c, I think you can add similar test

OK, I'll try to find the time to test this later this week. I have also some 
more on my todo list regarding documentation and testing. If you don't hear 
back from me though, I'd appreciate if someone could adopt this patch and make 
sure it gets integrated.

Cheers
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]