Re: [PATCH] perf report: Support caller callchain order when using DWARF unwinder.

[Milian Wolff <milian.wolff@kdab.com>]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On Tuesday, November 3, 2015 9:06:31 AM CET Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 03, 2015 at 08:33:25AM +0100, Jiri Olsa escreveu:
> > On Mon, Nov 02, 2015 at 06:19:44PM -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > SNIP
> > 
> > > > > there's no check for return value of entry callback
> > > > > 
> > > > > also I wonder would it be better to store into ips[] within
> > > > > the single loop all the time, and iterate throught it after
> > > > > forward/backward based on the callchain_param.order
> > > > > 
> > > > > please check attached patch, totaly untested, probably leaking some
> > > > > index
> > > > > ;-)
> > > > > 
> > > > > any chance this could be done also for util/unwind-libdw.c ?
> > > > 
> > > > That patch looks much better than mine. I'll try it out later next
> > > > week and
> > > > will also have a look at util/unwind-libdw.c. Question: How can I test
> > > > the
> > > 
> > > So, you tried this patch, right? Jiri, have you submitted this in some
> > > other message I missed?
> > 
> > nope.. I thought Milian would take it ;-)
> 
> I can take it, as soon as you guys agree its something I should :-)

Yes, I think it's good as-is. Should I resubmit Jiris patch? Considering that 
he rewrote the patch, should he send it and add me as tester? How do you 
handle such situations in the Kernel land?

Thanks
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]