Re: [PATCH v3 5/6] perf arm_spe: Decode Arm N1 IMPDEF events

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Low] The include directive `#include "../../arm64/include/asm/cputype.h"` is logically malformed and relies on incidental include path traversal.
--

commit d5ca69ee6b857cf31887dc91dcc515d11d5cc894
Author: James Clark <james.clark@linaro.org>

perf arm_spe: Decode Arm N1 IMPDEF events

This commit adds a framework to decode Arm N1 implementation-defined (IMPDEF)
events not covered by the common list. It also increases the buffer size
used for event string decoding to prevent truncation.

Link: https://developer.arm.com/documentation/100616/0401/Statistical-Profiling-Extension/implementation-defined-features-of-SPE

> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> @@ -15,6 +15,8 @@
>  
>  #include "arm-spe-pkt-decoder.h"
>  
> +#include "../../arm64/include/asm/cputype.h"

This isn't a bug, but is this include directive relying on incidental include
path traversal?

The relative path ../../arm64/include/asm/cputype.h logically evaluates to
tools/perf/arm64/include/asm/cputype.h from this directory, which doesn't
exist in the source tree. It appears to compile only because the updated
Build file adds -I$(srctree)/tools/arch/arm64/include/ to the CFLAGS, causing
the preprocessor to append the relative path to the newly included directory.

Since the target base directory is already exposed via the -I flag, could
this be simplified to use #include <asm/cputype.h>?

> +
>  static const char * const arm_spe_packet_name[] = {
>  	[ARM_SPE_PAD]		= "PAD",

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260414-james-spe-impdef-decode-v3-0-63baf9c893b1@linaro.org?part=5