Re: [PATCH v3 1/6] perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Bogus parameter `@dbg` added to kernel-doc for `die_find_realfunc`.
--

commit 3f417cdb8c6fb98d5939fd0f506ef04fca29beeb
Author: Ian Rogers <irogers@google.com>

perf dwarf-aux: Fix libdw segmentation fault in cu_walk_functions_at

This commit fixes a segmentation fault in libdw when running perf kmem. It
corrects the error handling for dwarf_getfuncs in die_find_realfunc and
die_find_tailfunc to properly catch the error condition.

> diff --git a/tools/perf/util/dwarf-aux.c b/tools/perf/util/dwarf-aux.c
> --- a/tools/perf/util/dwarf-aux.c
> +++ b/tools/perf/util/dwarf-aux.c

[ ... ]

> @@ -647,6 +646,7 @@ static int __die_search_func_cb(Dwarf_Die *fn_die, void *data)
>   * die_find_realfunc - Search a non-inlined function at given address
>   * @cu_die: a CU DIE which including @addr
>   * @addr: target address
> + * @dbg: Dwarf session

This isn't a bug, but the dbg parameter is not actually part of the function
signature for die_find_realfunc. Will this trigger an excess function
parameter warning during kernel-doc builds?

>   * @die_mem: a buffer for result DIE
>   *
>   * Search a non-inlined function DIE which includes @addr. Stores the

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260503003552.1063540-1-irogers@google.com?part=1