Re: [PATCH v3 4/4] perf test: Add inject ASLR test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The claimed multi-arch address normalization feature is not implemented.
--

commit 7330768f7ec5b4d1676ce71056c223b55aff876e
Author: Ian Rogers <irogers@google.com>

perf test: Add inject ASLR test

This commit adds a new shell test inject_aslr.sh to verify the perf inject
--aslr feature. It covers various remapping scenarios, pipe modes,
callchains, and report consistency checks.

>     The test suite is hardened with:
>     - Global 'set -o pipefail' pipeline checks to catch failures in perf script.
>     - Safe awk processing loop closures that consume whole streams to avoid SIGPIPE
>       signal aborts.
>     - False success assertions to verify callchain data isn't dynamically dropped.
>     - Graceful error paths on empty sample records.
>     - Multi-arch support (32-bit and 64-bit address normalizations).

The commit message mentions multi-arch support and 32-bit and 64-bit address
normalizations, but it appears the script only normalizes the DSO names.

[ ... ]

> diff --git a/tools/perf/tests/shell/inject_aslr.sh b/tools/perf/tests/shell/inject_aslr.sh
> new file mode 100755
> index 000000000000..fa7dd3b4c411
> --- /dev/null
> +++ b/tools/perf/tests/shell/inject_aslr.sh

[ ... ]

> +test_kernel_report_aslr() {

[ ... ]

> +  # Strip headers and compare lines with percentages
> +  grep '%' "${report1}" | grep -v '^#' > "${report1_clean}" || true
> +  grep '%' "${report2}" | grep -v '^#' > "${report2_clean}" || true
> +
> +  # Normalize kernel DSOs and addresses in clean reports
> +  # This allows kernel modules to be either a module or kernel.kallsyms
> +  local report1_norm="${temp_dir}/report_kernel1.norm"
> +  local report2_norm="${temp_dir}/report_kernel2.norm"
> +
> +  awk '{gsub(/\[[a-zA-Z0-9_.-]{2,}\](\.[a-zA-Z0-9_]+)?/, "[kernel]", $0); \
> +        print}' "${report1_clean}" > "${report1_norm}"
> +  awk '{gsub(/\[[a-zA-Z0-9_.-]{2,}\](\.[a-zA-Z0-9_]+)?/, "[kernel]", $0); \
> +        print}' "${report2_clean}" > "${report2_norm}"

Does this awk script normalize memory addresses, or does it only normalize
the DSO names?

The code seems to avoid address-related diff failures by summing the percentage
column later, rather than normalizing the addresses themselves.

Could the commit message and the inline comment be updated to accurately
describe what the script actually normalizes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504035125.1851720-1-irogers@google.com?part=4