Re: [PATCH v4 4/4] perf test: Add inject ASLR test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The test script claims to perform address normalization for kernel reports but fails to implement it in the awk substitution.
--

commit 35a72f67733a9ae0ed75cf3ba7c2a7ec0e4419cd
Author: Ian Rogers <irogers@google.com>

perf test: Add inject ASLR test

This commit adds a new shell test, inject_aslr.sh, to verify the perf inject
--aslr feature. It covers various scenarios including basic address remapping,
pipe modes, callchains, and kernel address remapping consistency.

> diff --git a/tools/perf/tests/shell/inject_aslr.sh b/tools/perf/tests/shell/inject_aslr.sh
> new file mode 100755
> index 000000000000..80ec9bf3daf8
> --- /dev/null
> +++ b/tools/perf/tests/shell/inject_aslr.sh

[ ... ]

> +test_kernel_report_aslr() {

[ ... ]

> +  # Normalize kernel DSOs and addresses in clean reports
> +  # This allows kernel modules to be either a module or kernel.kallsyms
> +  local report1_norm="${temp_dir}/report_kernel1.norm"
> +  local report2_norm="${temp_dir}/report_kernel2.norm"
> +  local diff_file="${temp_dir}/diff_kernel"
> +
> +  awk '{gsub(/\[[a-zA-Z0-9_.-]{2,}\](\.[a-zA-Z0-9_]+)?/, "[kernel]", $0); \
> +        print}' "${report1_clean}" | sort > "${report1_norm}"
> +  awk '{gsub(/\[[a-zA-Z0-9_.-]{2,}\](\.[a-zA-Z0-9_]+)?/, "[kernel]", $0); \
> +        print}' "${report2_clean}" | sort > "${report2_norm}"

The commit message mentions "32-bit and 64-bit address normalizations", and
the inline comment here specifically states it will normalize addresses.

However, the awk substitution appears to only match and replace the DSO
module names.

If unresolved kernel symbols are present in the trace, perf report will
output their absolute hexadecimal addresses. Since --aslr shifts these
addresses, wouldn't the unnormalized hex strings differ between the
original and injected reports?

Could this cause the diff check to fail on environments lacking full kernel
symbol resolution, leading to flaky test failures?

> +
> +  diff -u -w "${report1_norm}" "${report2_norm}" > "${diff_file}" || true

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504072937.2103453-1-irogers@google.com?part=4