Re: [PATCH v7 02/20] KVM: arm64: Reorganize PMU includes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] `include/kvm/arm_pmu.h` is no longer self-contained because it relies on `has_vhe()` without including `<asm/virt.h>`.
--

commit 016ed8cf72a663237c0c6836305a2edc3ef74982
Author: Marc Zyngier <maz@kernel.org>

KVM: arm64: Reorganize PMU includes

This commit reorganizes the PMU includes to resolve a circular dependency
between asm/kvm_host.h and asm/arm_pmuv3.h. It removes the inclusion of
kvm_host.h from arm_pmuv3.h and moves the remaining KVM/PMU interfaces into
arm_pmu.h.

[ ... ]

> diff --git a/include/kvm/arm_pmu.h b/include/kvm/arm_pmu.h
> index 96754b51b4116..e91d15a7a564b 100644
> --- a/include/kvm/arm_pmu.h
> +++ b/include/kvm/arm_pmu.h
> @@ -9,9 +9,19 @@
>  
>  #include <linux/perf_event.h>
>  #include <linux/perf/arm_pmuv3.h>
> +#include <linux/perf/arm_pmu.h>
>  
>  #define KVM_ARMV8_PMU_MAX_COUNTERS	32
>  
> +#define kvm_pmu_counter_deferred(attr)			\
> +	({						\
> +		!has_vhe() && (attr)->exclude_host;	\
> +	})

This isn't a bug, but by converting kvm_pmu_counter_deferred() from a static
inline function to a macro, do we lose type checking on the attr argument?

Additionally, this macro relies on has_vhe(), but asm/virt.h is not included
in this header. Does this leave the header no longer self-contained, relying
on callers to include asm/virt.h before using this macro?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504211813.1804997-1-coltonlewis@google.com?part=2