Re: [PATCH v7 03/20] KVM: arm64: Reorganize PMU functions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Redundant macro definition of `kvm_arm_pmu_irq_initialized`.
- [Low] Missing `#include <linux/uaccess.h>` in `arch/arm64/kvm/pmu.c`.
--

commit 9aeaae469d996e1d76ed323e65048d5b72469b0b
Author: Colton Lewis <coltonlewis@google.com>

KVM: arm64: Reorganize PMU functions

A lot of functions in pmu-emul.c aren't specific to the emulated PMU
implementation. Move them to the more appropriate pmu.c file where
shared PMU functions should live.

> diff --git a/arch/arm64/kvm/pmu.c b/arch/arm64/kvm/pmu.c
> index 6b48a3d16d0d5..ee2f0f7e61bcf 100644
> --- a/arch/arm64/kvm/pmu.c
> +++ b/arch/arm64/kvm/pmu.c
> @@ -8,8 +8,22 @@
>  #include <linux/perf/arm_pmu.h>
>  #include <linux/perf/arm_pmuv3.h>
>  
> +#include <kvm/arm_pmu.h>
> +
> +#include <asm/kvm_emulate.h>

This isn't a bug, but should linux/uaccess.h be explicitly included here?

The refactoring moved functions like kvm_arm_pmu_v3_set_attr() to this file,
which rely on get_user() and copy_from_user().

> +static LIST_HEAD(arm_pmus);
> +static DEFINE_MUTEX(arm_pmus_lock);
>  static DEFINE_PER_CPU(struct kvm_pmu_events, kvm_pmu_events);
>  
> +#define kvm_arm_pmu_irq_initialized(v)	((v)->arch.pmu.irq_num >= VGIC_NR_SGIS)

Is this macro definition redundant?

It appears that kvm_arm_pmu_irq_initialized() is already defined in
include/kvm/arm_pmu.h, and this file includes kvm/arm_pmu.h just above.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260504211813.1804997-1-coltonlewis@google.com?part=3