Re: [RFC PATCH v1 11/14] perf stat: Extend JSON output linter to test core aggregation checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Reusing the same test functions for the `--new` API pass results in indistinguishable log messages, making debugging difficult.
--

commit 757070262571c3df3509bd31055f9fb6103f0ded
Author: Ian Rogers <irogers@google.com>

perf stat: Extend JSON output linter to test core aggregation checks

This commit extends the stat+json_output.sh script to test core aggregation
checks using the new JSON print API. It introduces a perf_new_opt variable
and runs the existing checking functions a second time with the --new flag
to validate the zero-allocation print callbacks.

> diff --git a/tools/perf/tests/shell/stat+json_output.sh b/tools/perf/tests/shell/stat+json_output.sh
> --- a/tools/perf/tests/shell/stat+json_output.sh
> +++ b/tools/perf/tests/shell/stat+json_output.sh
[ ... ]
> @@ -36,7 +37,7 @@ function ParanoidAndNotRoot()
>  check_no_args()
>  {
>  	echo -n "Checking json output: no args "
> -	perf stat -j -o "${stat_output}" true
> +	perf stat -j $perf_new_opt -o "${stat_output}" true
>  	$PYTHON $pythonchecker --no-args --file "${stat_output}"
>  	echo "[Success]"
>  }
[ ... ]
> @@ -232,5 +233,21 @@ then
>  else
>  	echo "[Skip] Skipping tests for system_wide_no_aggr, per_core, per_die and per_socket since socket id exposed via topology is invalid"
>  fi
> +# Run New API JSON basic and standard aggregation checks
> +perf_new_opt="--new"
> +check_no_args

[Severity: Low]
Does reusing the same test functions for the --new API pass result in
indistinguishable log messages?

The status output (e.g., echo -n "Checking json output: no args ") is
hardcoded in the functions and does not print the perf_new_opt value.
This means the test log will contain duplicate identical lines for the
two passes.

Could this make it difficult to determine which API mode failed during
automated testing?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522223342.2393553-1-irogers@google.com?part=11