Re: [RFC PATCH v2 14/14] perf stat: Extend PMU metrics value linter to validate --new outputs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The New API validation run overwrites debug artifacts generated by the legacy validation run.
--

commit 40eff85b19a584a903ea2292617705adf84c2b46
Author: Ian Rogers <irogers@google.com>

perf stat: Extend PMU metrics value linter to validate --new outputs

This patch updates the stat_metrics_values.sh test to run the validation
linter a second time using the --new flag to ensure new Intel PMU metric
outputs are validated.

> diff --git a/tools/perf/tests/shell/stat_metrics_values.sh b/tools/perf/tests/shell/stat_metrics_values.sh
> --- a/tools/perf/tests/shell/stat_metrics_values.sh
> +++ b/tools/perf/tests/shell/stat_metrics_values.sh
> @@ -22,9 +22,20 @@ for cputype in /sys/bus/event_source/devices/cpu_*; do
>  	$PYTHON $pythonvalidator -rule $rulefile -output_dir $tmpdir -wl "${workload}" \
>  		-cputype "${cputype}"
>  	ret=$?
> -	rm -rf $tmpdir
>  	if [ $ret -ne 0 ]; then
>  		echo "Metric validation return with errors. Please check metrics reported with errors."
> +		rm -rf $tmpdir
> +		exit $ret
> +	fi
> +
> +	echo "Testing metrics for: $cputype (New API)"
> +	$PYTHON $pythonvalidator -rule $rulefile -output_dir $tmpdir -wl "${workload}" \
> +		-cputype "${cputype}" -new

[Severity: Low]
Does reusing the same $tmpdir here overwrite the debug artifacts from the
legacy validation run?

If a developer manually adds the -debug flag for troubleshooting, it appears
the second python execution will silently overwrite the artifacts (such as
perf_report.json and perf_data.json) generated by the first execution.

Would writing to separate subdirectories help preserve both sets of debug
artifacts?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525231900.3527228-1-irogers@google.com?part=14