Re: [PATCH v3 01/14] perf jevents.py: Make generated C code more kernel style

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `/* clang-format off */` directive in generated split C files, leaving an unmatched `/* clang-format on */`.
--

commit 69b593c82711e122a96b992aa3098ed70fbdacb2
Author: Ian Rogers <irogers@google.com>

perf jevents.py: Make generated C code more kernel style

This commit updates jevents.py to make the generated C code comply with
kernel formatting tools. It adds clang-format directives to bypass large
generated tables and fixes indentation and line length issues.

> diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
> index 7344940e776a6..6f80f937f9f94 100755
> --- a/tools/perf/pmu-events/jevents.py
> +++ b/tools/perf/pmu-events/jevents.py
[ ... ]
> @@ -1466,6 +1463,7 @@ struct pmu_table_entry {
>  
>    _bcs.compute()
>    if not _args.output_string_file:
> +    _args.output_file.write('/* clang-format off */\n')
>      _args.output_file.write('static const char *const big_c_string =\n')
>      for s in _bcs.big_string:
>        _args.output_file.write(s)
[ ... ]
> @@ -1487,6 +1485,7 @@ struct pmu_table_entry {
>  
>    print_mapping_table(archs)
>    print_system_mapping_table()
> +  _args.output_file.write('/* clang-format on */\n')

[Severity: Low]
If _args.output_string_file is provided, we skip writing the initial
/* clang-format off */ directive in the block above. However, the 
/* clang-format on */ directive is written unconditionally here. 

Could this result in an unmatched formatting directive when outputting to 
split C files, potentially breaking clang-format checks instead of bypassing
the large tables as intended?

>    print_metricgroups()
>    _args.output_file.close()
>    if _args.output_string_file:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260531063736.871777-1-irogers@google.com?part=1