Re: [PATCH v4 10/15] perf test: Fix subtest status alignment for multi-digit indexes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The ternary condition `len >= 4` used to guard the `subw` calculation is a tautology.
--

commit 769ba0590c3bfba1dad8b4eb8bbb7b78766b7efe
Author: Ian Rogers <irogers@google.com>

perf test: Fix subtest status alignment for multi-digit indexes

This commit dynamically calculates the subtest description width based on
the exact length of the test suite and subtest index prefix. This ensures
the status column remains vertically aligned across different index lengths.

> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -373,10 +373,12 @@ static int print_test_result(struct test_suite *t, int curr_suite, int curr_test
>  			     int result, int width, int running)
>  {
>  	if (test_suite__num_test_cases(t) > 1) {
> -		int subw = width > 2 ? width - 2 : width;
> +		char prefix[32];
> +		int len = snprintf(prefix, sizeof(prefix), "%3d.%1d:",
> +				   curr_suite + 1, curr_test_case + 1);
> +		int subw = len >= 4 ? width + 4 - len : width;

[Severity: Low]
Is the condition len >= 4 a tautology here? Because the format string
"%3d.%1d:" will always produce at least 6 characters (3 for %3d, 1 for the
dot, at least 1 for %1d, and 1 for the colon), len will always be >= 6.

If the goal was to prevent subw from becoming negative, should this check
evaluate width instead (for example, width + 4 >= len)?

> -		pr_info("%3d.%1d: %-*s:", curr_suite + 1, curr_test_case + 1, subw,
> -			test_description(t, curr_test_case));
> +		pr_info("%s %-*s:", prefix, subw, test_description(t, curr_test_case));
>  	} else
>  		pr_info("%3d: %-*s:", curr_suite + 1, width, test_description(t, curr_test_case));

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260531082235.940833-1-irogers@google.com?part=10