From: Jens Remus <jremus@linux.ibm.com>
To: linux-s390@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jens Remus <jremus@linux.ibm.com>,
Jan Polensky <japo@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Hendrik Brueckner <brueckner@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>
Subject: [PATCH] perf build: Do not duplicate CFLAGS in Python extension builds
Date: Wed, 10 Jun 2026 13:23:43 +0200 [thread overview]
Message-ID: <20260610112344.1550111-1-jremus@linux.ibm.com> (raw)
setuptools already uses CFLAGS. Passing CFLAGS with additional flags as
extra compile arguments causes CFLAGS to effectively get passed twice:
$ make -C tools/perf V=1 JOBS=1
...
building 'perf' extension
gcc [CFLAGS] -fPIC -Iutil/include -I/usr/include/python3.14 \
-c /root/linux/tools/perf/util/python.c \
-o python_ext_build/tmp/root/linux/tools/perf/util/python.o \
[CFLAGS] \
-fno-strict-aliasing -Wno-write-strings -Wno-unused-parameter \
-Wno-redundant-decls -Wno-cast-function-type \
-Wno-declaration-after-statement
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---
Notes (jremus):
This patch applies on top of the perf-tools-next tree:
git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git master
Note that my "[PATCH v2] perf build: Respect V=1 for Python extension
builds" [1] needs to be applied to actually observe the Python extension
build command and output with V=1.
[1]: https://lore.kernel.org/all/20260608160613.3153795-1-jremus@linux.ibm.com/
tools/perf/util/setup.py | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index b65b1792ca05..a0ce76624a23 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -74,18 +74,17 @@ class install_lib(_install_lib):
self.build_dir = build_lib
-cflags = getenv('CFLAGS', '').split()
# switch off several checks (need to be at the end of cflags list)
-cflags += ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ]
+extra_cflags = ['-fno-strict-aliasing', '-Wno-write-strings', '-Wno-unused-parameter', '-Wno-redundant-decls' ]
if cc_is_clang:
- cflags += ["-Wno-unused-command-line-argument" ]
+ extra_cflags += ["-Wno-unused-command-line-argument" ]
if clang_has_option("-Wno-cast-function-type-mismatch"):
- cflags += ["-Wno-cast-function-type-mismatch" ]
+ extra_cflags += ["-Wno-cast-function-type-mismatch" ]
else:
- cflags += ['-Wno-cast-function-type' ]
+ extra_cflags += ['-Wno-cast-function-type' ]
# The python headers have mixed code with declarations (decls after asserts, for instance)
-cflags += [ "-Wno-declaration-after-statement" ]
+extra_cflags += [ "-Wno-declaration-after-statement" ]
src_perf = f'{srctree}/tools/perf'
build_lib = getenv('PYTHON_EXTBUILD_LIB')
@@ -94,7 +93,7 @@ build_tmp = getenv('PYTHON_EXTBUILD_TMP')
perf = Extension('perf',
sources = [ src_perf + '/util/python.c' ],
include_dirs = ['util/include'],
- extra_compile_args = cflags,
+ extra_compile_args = extra_cflags,
)
setup(name='perf',
--
2.53.0
next reply other threads:[~2026-06-10 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 11:23 Jens Remus [this message]
2026-06-10 13:38 ` [PATCH] perf build: Do not duplicate CFLAGS in Python extension builds James Clark
2026-06-10 20:02 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2026-06-10 11:13 Jens Remus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610112344.1550111-1-jremus@linux.ibm.com \
--to=jremus@linux.ibm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=japo@linux.ibm.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox