From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@linaro.org>
Cc: Jens Remus <jremus@linux.ibm.com>,
Jan Polensky <japo@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Hendrik Brueckner <brueckner@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
linux-s390@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build: Do not duplicate CFLAGS in Python extension builds
Date: Wed, 10 Jun 2026 17:02:32 -0300 [thread overview]
Message-ID: <ainC2J-eMxlcUSjC@x1> (raw)
In-Reply-To: <82e8f48d-50da-4010-9df2-82dfd436d85c@linaro.org>
On Wed, Jun 10, 2026 at 02:38:24PM +0100, James Clark wrote:
>
>
> On 10/06/2026 12:23 pm, Jens Remus wrote:
> > setuptools already uses CFLAGS. Passing CFLAGS with additional flags as
> > extra compile arguments causes CFLAGS to effectively get passed twice:
> >
> > $ make -C tools/perf V=1 JOBS=1
> > ...
> > building 'perf' extension
> > gcc [CFLAGS] -fPIC -Iutil/include -I/usr/include/python3.14 \
> > -c /root/linux/tools/perf/util/python.c \
> > -o python_ext_build/tmp/root/linux/tools/perf/util/python.o \
> > [CFLAGS] \
> > -fno-strict-aliasing -Wno-write-strings -Wno-unused-parameter \
> > -Wno-redundant-decls -Wno-cast-function-type \
> > -Wno-declaration-after-statement
> >
> > Signed-off-by: Jens Remus <jremus@linux.ibm.com>
>
> Reviewed-by: James Clark <james.clark@linaro.org>
Thanks, applied to perf-tools-next, for v7.2.
- Arnaldo
next prev parent reply other threads:[~2026-06-10 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 11:23 [PATCH] perf build: Do not duplicate CFLAGS in Python extension builds Jens Remus
2026-06-10 13:38 ` James Clark
2026-06-10 20:02 ` Arnaldo Carvalho de Melo [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-10 11:13 Jens Remus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ainC2J-eMxlcUSjC@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=japo@linux.ibm.com \
--cc=jolsa@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox