Re: [Patch v9 03/10] tools headers: Sync x86 headers with kernel sources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Modifying a tools header without a corresponding kernel header update causes a synchronization divergence and triggers build warnings.
--

commit f29e894bc895095793a45b66351922174d49d6a4
Author: Dapeng Mi <dapeng1.mi@linux.intel.com>

tools headers: Sync x86 headers with kernel sources

This commit attempts to synchronize the x86 msr-index.h header in the
tools directory with the kernel sources by adding ARCH_PEBS_VECR_xxx
macros.

> diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h
> index eff29645719bc..8cbc4c4997065 100644
> --- a/tools/arch/x86/include/asm/msr-index.h
> +++ b/tools/arch/x86/include/asm/msr-index.h
> @@ -350,6 +350,13 @@
>  #define ARCH_PEBS_LBR_SHIFT		40
>  #define ARCH_PEBS_LBR			(0x3ull << ARCH_PEBS_LBR_SHIFT)
>  #define ARCH_PEBS_VECR_XMM		BIT_ULL(49)
> +#define ARCH_PEBS_VECR_YMMH		BIT_ULL(50)

[Severity: Low]
Will this trigger a Kernel ABI header differences warning during the perf build?

If the corresponding kernel-side macros are not already present in the
arch/x86/include/asm/msr-index.h header of the tree this patch is applied
against, check-headers.sh will flag a synchronization divergence. 

Are these macros being merged in a separate patch series that needs to be
applied first, or did the kernel counterpart miss getting included in this
series?

> +#define ARCH_PEBS_VECR_EGPRS		BIT_ULL(51)
> +#define ARCH_PEBS_VECR_OPMASK		BIT_ULL(53)
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706023444.3067660-1-dapeng1.mi@linux.intel.com?part=3