Re: [PATCH v4 2/9] perf ui hists: In report UI ensure thread is set

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit intentionally uses raw pointer assignments for reference-counted structs, violating the subsystem's explicit lifecycle guidelines.
--

--- Patch [2]: [PATCH v4 2/9] perf ui hists: In report UI ensure thread is set ---
commit bd1f6d1690697868f7f32902eeee4100a0837b56
Author: Ian Rogers <irogers@google.com>

perf ui hists: In report UI ensure thread is set

This commit populates the map_symbol thread in the UI code to fix the
e_machine lookup for cross-platform disassembly when using the annotate
action.

> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 671961946d56c..c6cfbcc580617 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -3155,10 +3155,12 @@ static int evsel__hists_browse(struct evsel *evsel, int nr_events, const char *h
>  						continue;
>  
>  					actions->ms.sym = symbol__new_unresolved(bi->to.al_addr, bi->to.ms.map);
> +					actions->ms.thread = bi->to.ms.thread;
> +					actions->ms.map = bi->to.ms.map;

[Severity: Medium]
The commit message notes the intentional use of raw pointers to avoid having
to clean up references. However, does this violate the perf subsystem
guidelines which strictly require using explicit thread__get() and
thread__put() lifecycle helpers for reference-counted structs like thread
and map? 

Could bypassing the reference counting abstraction here make the code more
fragile to use-after-free defects if the lifecycle of actions->ms.thread is
modified in the future?

>  				} else {
>  					actions->ms.sym = symbol__new_unresolved(browser->he_selection->ip,
>  										 browser->selection->map);
> +					actions->ms.thread = browser->selection->thread;
> +					actions->ms.map = browser->selection->map;
>  				}

[ ... ]

> @@ -3173,6 +3175,7 @@ static int evsel__hists_browse(struct evsel *evsel, int nr_events, const char *h
>  					continue;
>  				}
>  
> +				actions->ms.thread = browser->selection->thread;
>  				actions->ms.map = browser->selection->map;
>  				actions->ms.sym = browser->selection->sym;
>  			}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710024952.1668911-1-irogers@google.com?part=2