From: sashiko-bot@kernel.org
To: "Chun-Tse Shao" <ctshao@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 09/12] perf vendor events intel: Add novalake v1.00 events
Date: Mon, 13 Jul 2026 18:31:19 +0000 [thread overview]
Message-ID: <20260713183119.C3A2B1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260713181757.481164-10-ctshao@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The CPUID matching regex for novalake expects a zero-padded model ('0[13]'), but perf generates the CPUID string using '%X' without zero-padding, meaning the events will fail to load.
--
--- Patch [9]: [PATCH v1 09/12] perf vendor events intel: Add novalake v1.00 events ---
commit 5f5b010b3f6aa216e7d15989744fc8646fec9af1
Author: Chun-Tse Shao <ctshao@google.com>
perf vendor events intel: Add novalake v1.00 events
This commit adds performance monitoring events for the Intel Novalake
architecture. It introduces new JSON event definition files and updates the
x86 mapfile to associate the new models with these events.
> diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv
> index a15cd32809937..d88a22d9de72b 100644
> --- a/tools/perf/pmu-events/arch/x86/mapfile.csv
> +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv
> @@ -39,6 +39,7 @@ GenuineIntel-6-8[CD],v1.19,tigerlake,core
> GenuineIntel-6-2C,v5,westmereep-dp,core
> GenuineIntel-6-25,v4,westmereep-sp,core
> GenuineIntel-6-2F,v4,westmereex,core
> +GenuineIntel-18-0[13],v1.00,novalake,core
[Severity: Medium]
Will this regex fail to match the actual CPUID string generated by perf?
When perf runs on a Novalake processor, get_cpuid_str() formats the CPUID
using %s-%u-%X-%X$. For Novalake models 0x01 and 0x03, the %X format
specifier does not zero-pad the output. This results in a CPUID string
like GenuineIntel-18-1 or GenuineIntel-18-3.
Since this regex explicitly expects a leading zero (0[13]), it looks like
it won't match the unpadded string, causing the new events to be
unavailable. Should this be GenuineIntel-18-[13] instead?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260713181757.481164-1-ctshao@google.com?part=9
next prev parent reply other threads:[~2026-07-13 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 18:17 [PATCH v1 0/12] perf vendor events intel: update Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 01/12] perf vendor events intel: Update alderlake events from 1.39 to 1.40 Chun-Tse Shao
2026-07-13 18:27 ` sashiko-bot
2026-07-13 18:17 ` [PATCH v1 02/12] perf vendor events intel: Update alderlaken " Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 03/12] perf vendor events intel: Update arrowlake events from 1.19 to 1.20 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 04/12] perf vendor events intel: Update clearwaterforest events from 1.02 to 1.04 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 05/12] perf vendor events intel: Update grandridge events from 1.12 to 1.13 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 06/12] perf vendor events intel: Update graniterapids events from 1.19 to 1.20 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 07/12] perf vendor events intel: Update lunarlake events from 1.25 to 1.26 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 08/12] perf vendor events intel: Update meteorlake events from 1.21 to 1.22 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 09/12] perf vendor events intel: Add novalake v1.00 events Chun-Tse Shao
2026-07-13 18:31 ` sashiko-bot [this message]
2026-07-13 18:17 ` [PATCH v1 10/12] perf vendor events intel: Update pantherlake events from 1.06 to 1.07 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 11/12] perf vendor events intel: Update sierraforest events from 1.17 to 1.18 Chun-Tse Shao
2026-07-13 18:17 ` [PATCH v1 12/12] perf vendor events intel: Update emeraldrapids metrics Chun-Tse Shao
2026-07-14 5:21 ` [PATCH v1 0/12] perf vendor events intel: update Mi, Dapeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713183119.C3A2B1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ctshao@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox