Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Besar Wicaksono" <bwicaksono@nvidia.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] perf vendor events arm64: fix swapped MetricGroup for Tegra410 L1 prefetcher metrics
Date: Thu, 13 Aug 2026 17:11:35 +0000	[thread overview]
Message-ID: <20260813171136.5E26F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260813170155.1156593-2-bwicaksono@nvidia.com>

> From: Saurav Sachidanand <sauravsc@amazon.com>
> 
> The L1D prefetcher metrics (l1d_cache_rw_miss_ratio, l1d_demand_accesses,
> etc.) were incorrectly assigned to MetricGroup "L1I_Prefetcher_Effectiveness"
> and vice versa. This causes 'perf stat --metric-group L1D_Prefetcher_Effectiveness'
> to display L1I metrics, which is misleading.
> 
> Swap the MetricGroup assignments so L1D metrics are in the L1D group and
> L1I metrics are in the L1I group.
> 
> Fixes: 86ff690f45cc ("perf vendor events arm64: Add Tegra410 Olympus PMU events")
> Signed-off-by: Saurav Sachidanand <sauravsc@amazon.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260813170155.1156593-1-bwicaksono@nvidia.com?part=1


  reply	other threads:[~2026-08-13 17:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 17:01 [PATCH 0/2] perf vendor events arm64: Fix Tegra410 Olympus PMU events Besar Wicaksono
2026-08-13 17:01 ` [PATCH 1/2] perf vendor events arm64: fix swapped MetricGroup for Tegra410 L1 prefetcher metrics Besar Wicaksono
2026-08-13 17:11   ` sashiko-bot [this message]
2026-08-13 17:01 ` [PATCH 2/2] perf vendor events arm64: Fix Tegra410 Olympus event 0x0197 Besar Wicaksono
2026-08-13 17:08   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813171136.5E26F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bwicaksono@nvidia.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox