From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 3/3] perf header: Fix potential memory corruption in cpu_cache_level__read
Date: Thu, 10 Sep 2026 18:08:15 +0000 [thread overview]
Message-ID: <20260910180815.87F041F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260910175634.3014018-3-irogers@google.com>
> strim may advance the pointer assigned to cache->size which causes
> later frees to crash. Fix by performing the strim and then memmove-ing
> the potentially shifted string back over the original string. The bug
> was introduced by the transition from rtrim to strim, as rtrim
> wouldn't move on the left.
>
> Fixes: 13c230ab6e56 ("perf tools: Ditch rtrim(), use strim() from tools/lib")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910175634.3014018-1-irogers@google.com?part=3
next prev parent reply other threads:[~2026-09-10 18:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 17:37 [PATCH v1 1/3] perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len Ian Rogers
2026-09-10 17:37 ` [PATCH v1 2/3] perf header: Fix potential memory corruption in cpu_cache_level__read Ian Rogers
2026-09-10 17:47 ` sashiko-bot
2026-09-10 17:37 ` [PATCH v1 3/3] perf header: Transition WARN macros to debug.h equivalents Ian Rogers
2026-09-10 17:46 ` sashiko-bot
2026-09-10 17:51 ` [PATCH v1 1/3] perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len sashiko-bot
2026-09-10 17:56 ` [PATCH v2 1/3] perf test x86: Fix missing __msan_unpoison Ian Rogers
2026-09-10 17:56 ` [PATCH v2 2/3] perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len Ian Rogers
2026-09-10 18:14 ` sashiko-bot
2026-09-10 17:56 ` [PATCH v2 3/3] perf header: Fix potential memory corruption in cpu_cache_level__read Ian Rogers
2026-09-10 18:08 ` sashiko-bot [this message]
2026-09-10 18:11 ` [PATCH v2 1/3] perf test x86: Fix missing __msan_unpoison sashiko-bot
2026-09-10 21:12 ` [PATCH v3 0/3] perf header: Fix memory corruption and unnecessary warning Ian Rogers
2026-09-10 21:12 ` [PATCH v3 1/3] perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len Ian Rogers
2026-09-10 21:21 ` sashiko-bot
2026-09-10 21:12 ` [PATCH v3 2/3] perf header: Fix potential memory corruption in cpu_cache_level__read Ian Rogers
2026-09-10 21:22 ` sashiko-bot
2026-09-10 21:12 ` [PATCH v3 3/3] perf header: Transition WARN macros to debug.h equivalents Ian Rogers
2026-09-10 21:18 ` sashiko-bot
2026-09-13 21:42 ` [PATCH v3 0/3] perf header: Fix memory corruption and unnecessary warning Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910180815.87F041F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox