Re: [PATCH v2 2/3] perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removal of `../perf.h` leaves `MAX_NR_CPUS` undefined, breaking compilation.
--

commit 6870b0e134392a29ae6d615a0881f18783b3b995
Author: Ian Rogers <irogers@google.com>

perf header: Fix HEADER_COMPRESSED validation for comp_mmap_len

This commit updates process_compressed() to ignore a zero size for 
comp_mmap_len when validating the compressed header. It also opportunistically
sorts the header files and fixes a missing string.h inclusion.

> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index 7db7da090a1e0..bdd79d7542ef1 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
[ ... ]
> -#include "data.h"
> -#include <api/fs/fs.h>
> -#include <api/io_dir.h>
> -#include "asm/bug.h"
> -#include "tool.h"
> -#include "../perf.h"

[Severity: Low]
Does removing the include for perf.h cause a build failure?

It appears perf.h provides the definition for MAX_NR_CPUS, which is used
to size arrays in existing functions like build_cpu_domain_map() within this 
same file:

    char dname[DNAME_LEN], cpumask[MAX_NR_CPUS];
    struct domain_info *domain_info;
    struct cpu_domain_map **cd_map;
    char cpulist[MAX_NR_CPUS];

Without an alternative definition for MAX_NR_CPUS, the compiler fails to
resolve the size of these arrays.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910175634.3014018-1-irogers@google.com?part=2