Re: [PATCH v6 13/26] perf annotate-arm64: Enable instruction tracking support

[sashiko-bot@kernel.org]

> Enable basic instruction tracking for arm64 by implementing three
> essential functions in the find_data_type_block() call path:
> 
>   find_data_type_block
>     -> arch_supports_insn_tracking  (1)
>     -> find_data_type_insn
>          -> init_type_state         (2)
>          -> update_var_state
>          -> update_insn_state       (3)
> 
> Changes:
> 
> * arch_supports_insn_tracking(): add arm64 to the list of supported
>   architectures, allowing find_data_type_block() to proceed with data
>   type analysis.
> 
> * init_type_state(): correctly identify ret_reg, stack_reg, and
>   caller-saved registers for arm64 during type state initialization.
> 
> * update_insn_state(): add the update_insn_state_arm64() callback with
>   conservative register invalidation for call instructions and those with
>   destination register(s), preventing stale type propagation. Full
>   instruction-level analysis support will be added incrementally in
>   later patches.
> 
> With these changes, arm64 gains support for basic variable type
> inference during instruction tracking.
> 
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
> Signed-off-by: Tengda Wu <wutengda@huaweicloud.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789521520.git.wutengda@huaweicloud.com?part=13