Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Thomas Falcon" <thomas.falcon@intel.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v11 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf()
Date: Wed, 23 Sep 2026 16:05:19 +0000	[thread overview]
Message-ID: <20260923160519.CBD551F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260923155703.34814-2-thomas.falcon@intel.com>

> When printing memory info in perf script, the entire size of the
> buffer is passed to perf_mem__lvl_scnprintf() instead of the remaining
> size. Pass the remaining buffer size instead.
> 
> This issue was detected by sashiko during an internal code review.
> 
> Assisted-by: Sashiko:gemini-3.1-pro-preview
> Fixes: fdefc3750e847 ("perf mem: Print memory operation type")
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Ian Rogers <irogers@google.com>
> Reviewed-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Thomas Falcon <thomas.falcon@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923155703.34814-1-thomas.falcon@intel.com?part=1


  reply	other threads:[~2026-09-23 16:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23 15:56 [PATCH v11 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-23 15:56 ` [PATCH v11 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-09-23 16:05   ` sashiko-bot [this message]
2026-09-23 15:56 ` [PATCH v11 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-09-23 16:13   ` sashiko-bot
2026-09-23 15:57 ` [PATCH v11 3/6] perf header: Support memory ranges Thomas Falcon
2026-09-23 16:10   ` sashiko-bot
2026-09-23 17:08     ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-09-23 17:08       ` [PATCH v12 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-09-23 17:17         ` sashiko-bot
2026-09-23 17:08       ` [PATCH v12 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-09-23 17:16         ` sashiko-bot
2026-09-23 17:09       ` [PATCH v12 3/6] perf header: Support memory ranges Thomas Falcon
2026-09-23 17:18         ` sashiko-bot
2026-09-23 17:09       ` [PATCH v12 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-09-23 17:17         ` sashiko-bot
2026-09-24  0:23         ` Mi, Dapeng
2026-09-24 17:28           ` Arnaldo Carvalho de Melo
2026-09-24 17:29             ` Arnaldo Carvalho de Melo
2026-09-23 17:09       ` [PATCH v12 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-09-23 17:22         ` sashiko-bot
2026-09-23 17:09       ` [PATCH v12 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-09-23 17:18         ` sashiko-bot
2026-09-24 17:35       ` [PATCH v12 0/6] perf: Add support for memory region/range reporting Arnaldo Carvalho de Melo
2026-09-23 15:57 ` [PATCH v11 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-09-23 16:04   ` sashiko-bot
2026-09-23 15:57 ` [PATCH v11 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-09-23 16:07   ` sashiko-bot
2026-09-23 15:57 ` [PATCH v11 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-09-23 16:05   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923160519.CBD551F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox