Re: [PATCH 3/5] perf report: Add --no-progress option

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf report: --no-progress option is shadowed by auto-negation of --progress
--

commit d8af0ed78a2918166c6bac5d18a4149df64706aa
Author: Arnaldo Carvalho de Melo <acme@redhat.com>

perf report: Add --no-progress option

This patch adds a --no-progress option to perf report to disable progress
information while processing the perf.data file. This takes precedence over
--progress and also turns off the default progress displays in the TUI and
GTK browsers.

> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 963808b561e54..e334556af62f9 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c

[ ... ]

> @@ -1387,6 +1388,8 @@ int cmd_report(int argc, const char **argv)
>  			"Show or hide weight columns in annotation. Default show if non-zero."),
>  	OPT_BOOLEAN(0, "progress", &report.progress,
>  		    "Show progress while processing the perf.data file"),
> +	OPT_BOOLEAN(0, "no-progress", &report.no_progress,
> +		    "Do not show progress while processing the perf.data file"),
>  	OPT_BOOLEAN(0, "header", &report.header, "Show data header."),

[Severity: Medium]
Since the "progress" option precedes "no-progress" in cmd_report(), does the
parse-options engine intercept the command line flag --no-progress as an
auto-negation of the earlier progress option?

If so, this would shadow the explicitly defined no-progress option, leaving
report.no_progress always unset.

[ ... ]

> @@ -1798,7 +1801,9 @@ int cmd_report(int argc, const char **argv)
>  	 * processed so far for each processing phase.  --quiet asks for no
>  	 * messages at all, so it leaves the phases uncounted.
>  	 */
> -	if (report.progress && !quiet && use_browser == 0)
> +	if (report.no_progress)
> +		ui_progress__noop_init();
> +	else if (report.progress && !quiet && use_browser == 0)
>  		stdio_progress__init();

[Severity: Medium]
If report.no_progress can never be true due to the parse-options shadowing
mentioned above, does this become dead code? This would prevent
ui_progress__noop_init() from executing and leave UI progress enabled despite
the flag being passed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260929201524.2507733-1-acme@kernel.org?part=3