From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 4/4] perf build: Fix clean and install target dependencies
Date: Thu, 01 Oct 2026 02:45:00 +0000 [thread overview]
Message-ID: <20261001024500.AFB6D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261001023423.1225713-5-irogers@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perf build: install% wildcard makes install-build-deps depend on all
--
commit 96fc82160f943f83538b4ed54809e23a269afef0
Author: Ian Rogers <irogers@google.com>
perf build: Fix clean and install target dependencies
Fix several missing dependencies and ordering issues for clean and
install targets.
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index b8d38728306ab..a0d7035cd97bb 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -93,6 +93,13 @@ ifeq ($(has_clean),1)
> $(rest): clean
> endif # rest
> endif # has_clean
> +
> +ifneq ($(filter all,$(MAKECMDGOALS)),)
> + install_goals := $(filter install%,$(MAKECMDGOALS))
> + ifneq ($(install_goals),)
> +$(install_goals): all
> + endif
> +endif
> endif # MAKECMDGOALS
[Severity: Medium]
Does the wildcard `install%` incorrectly capture `install-build-deps` here?
If a user executes a combined command like `make install-build-deps all`, this
will add `install-build-deps` to `install_goals` and create the dependency
`install-build-deps: all`.
Reversing this target dependency order forces the `all` target to compile perf
before the required system dependencies are installed, causing the build to
fail.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261001023423.1225713-1-irogers@google.com?part=4
next prev parent reply other threads:[~2026-10-01 2:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 2:34 [PATCH 0/4] perf build: Linter parallelism and clean/install dependency fixes Ian Rogers
2026-10-01 2:34 ` [PATCH 1/4] perf test: Update attr.py to use argparse Ian Rogers
2026-10-01 2:39 ` sashiko-bot
2026-10-01 2:34 ` [PATCH 2/4] perf build: Run shellcheck, mypy, and remaining pylint checks in parallel Ian Rogers
2026-10-01 2:39 ` sashiko-bot
2026-10-01 2:34 ` [PATCH 3/4] perf build: Clear GTK4 instead of setting unused NO_GTK4 when gtk4 is missing Ian Rogers
2026-10-01 2:40 ` sashiko-bot
2026-10-01 2:34 ` [PATCH 4/4] perf build: Fix clean and install target dependencies Ian Rogers
2026-10-01 2:45 ` sashiko-bot [this message]
2026-10-01 5:41 ` [PATCH v2 0/4] perf build: Linter parallelism and clean/install dependency fixes Ian Rogers
2026-10-01 5:41 ` [PATCH v2 1/4] perf test: Update attr.py to use argparse Ian Rogers
2026-10-01 5:44 ` sashiko-bot
2026-10-01 5:41 ` [PATCH v2 2/4] perf build: Run shellcheck, mypy, and remaining pylint checks in parallel Ian Rogers
2026-10-01 5:48 ` sashiko-bot
2026-10-01 5:41 ` [PATCH v2 3/4] perf build: Clear GTK4 instead of setting unused NO_GTK4 when gtk4 is missing Ian Rogers
2026-10-01 5:47 ` sashiko-bot
2026-10-01 5:41 ` [PATCH v2 4/4] perf build: Fix clean and install target dependencies Ian Rogers
2026-10-01 5:47 ` sashiko-bot
2026-10-01 15:54 ` [PATCH v2 0/4] perf build: Linter parallelism and clean/install dependency fixes Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261001024500.AFB6D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox