Linux Perf Users
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v2 1/4] perf test: Update attr.py to use argparse
Date: Thu, 01 Oct 2026 05:44:17 +0000	[thread overview]
Message-ID: <20261001054418.406871F00898@smtp.kernel.org> (raw)
In-Reply-To: <20261001054120.1570943-2-irogers@google.com>

> optparse is deprecated since Python 3.2 and triggers a pylint
> deprecated-module warning on newer versions of pylint. Replace
> optparse.OptionParser in tools/perf/tests/shell/lib/attr.py with
> argparse.ArgumentParser.
> 
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261001054120.1570943-1-irogers@google.com?part=1


  reply	other threads:[~2026-10-01  5:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-01  2:34 [PATCH 0/4] perf build: Linter parallelism and clean/install dependency fixes Ian Rogers
2026-10-01  2:34 ` [PATCH 1/4] perf test: Update attr.py to use argparse Ian Rogers
2026-10-01  2:39   ` sashiko-bot
2026-10-01  2:34 ` [PATCH 2/4] perf build: Run shellcheck, mypy, and remaining pylint checks in parallel Ian Rogers
2026-10-01  2:39   ` sashiko-bot
2026-10-01  2:34 ` [PATCH 3/4] perf build: Clear GTK4 instead of setting unused NO_GTK4 when gtk4 is missing Ian Rogers
2026-10-01  2:40   ` sashiko-bot
2026-10-01  2:34 ` [PATCH 4/4] perf build: Fix clean and install target dependencies Ian Rogers
2026-10-01  2:45   ` sashiko-bot
2026-10-01  5:41 ` [PATCH v2 0/4] perf build: Linter parallelism and clean/install dependency fixes Ian Rogers
2026-10-01  5:41   ` [PATCH v2 1/4] perf test: Update attr.py to use argparse Ian Rogers
2026-10-01  5:44     ` sashiko-bot [this message]
2026-10-01  5:41   ` [PATCH v2 2/4] perf build: Run shellcheck, mypy, and remaining pylint checks in parallel Ian Rogers
2026-10-01  5:48     ` sashiko-bot
2026-10-01  5:41   ` [PATCH v2 3/4] perf build: Clear GTK4 instead of setting unused NO_GTK4 when gtk4 is missing Ian Rogers
2026-10-01  5:47     ` sashiko-bot
2026-10-01  5:41   ` [PATCH v2 4/4] perf build: Fix clean and install target dependencies Ian Rogers
2026-10-01  5:47     ` sashiko-bot
2026-10-01 15:54   ` [PATCH v2 0/4] perf build: Linter parallelism and clean/install dependency fixes Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261001054418.406871F00898@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox