Re: [PATCH v10 6/9] perf report: Add --progress option

[sashiko-bot@kernel.org]

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Processing a large session with stdio output gives no feedback about
> which phase perf is in or how far along it is: ui_progress updates are
> only shown by the TUI.  Add --progress, installing a stdio backend
> (ui/stdio/progress.c) that prints the phase title, percentage and
> counts:
> 
>   Processing events... [ 42.3%] 317M / 746M
> 
> Phases can be nested, so the backend tracks the ones started to
> complete the right one on ui_progress__finish(); that requires
> init()/finish() pairs, fixed in ordered-events.c and the pipe and
> directory event processing.
> 
> With a pager both stdout and stderr lead to it, so isatty(stderr)
> turns false and the updates end up printed one per line in the
> pager's output: use /dev/tty in that case, so that the updates keep
> updating in place, untouched by the pager.
> 
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004102133.26392-1-acme@kernel.org?part=6