From: Rosen Penev <rosenp@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Radu Rendec <radu@rendec.net>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: [PATCH 4/4] irqchip/ath79-misc: allow COMPILE_TEST builds
Date: Thu, 12 Nov 2026 14:44:45 -0800 [thread overview]
Message-ID: <20261112224445.213324-5-rosenp@gmail.com> (raw)
In-Reply-To: <20261112224445.213324-1-rosenp@gmail.com>
The driver is only built with ATH79, so only ath79 kernels build it. As
a platform driver, its only MIPS-specific parts are the performance
counter hook and the call to spurious_interrupt().
Add a Kconfig symbol that defaults to ATH79 and can be enabled with
COMPILE_TEST. Build the performance counter hook only with ATH79, as
other MIPS platforms provide their own. Drop the call to
spurious_interrupt(), which only exists on MIPS: a cascaded interrupt
with nothing pending only bumped the error count in /proc/interrupts,
and the handler now just returns.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/irqchip/Kconfig | 14 ++++++++++++++
drivers/irqchip/Makefile | 2 +-
drivers/irqchip/irq-ath79-misc.c | 19 ++++++++++++-------
3 files changed, 27 insertions(+), 8 deletions(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 731041def5d6..91fcc433afab 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -127,6 +127,20 @@ config ASPEED_AST2700_INTC_TEST
If unsure, say N.
+config ATH79_MISC_IRQ
+ bool "Atheros/Qualcomm ath79 MISC interrupt controller" if COMPILE_TEST
+ depends on ATH79 || COMPILE_TEST
+ depends on OF
+ depends on HAS_IOMEM
+ default ATH79
+ select IRQ_DOMAIN
+ help
+ Support the MISC interrupt controller of the Atheros/Qualcomm
+ ath79 SoCs. It is cascaded from a CPU interrupt and collects the
+ interrupts of the UART, GPIO, timers, watchdog and performance
+ counters, among others. It is enabled by default on ath79, and
+ only needs to be selected by hand for compile testing.
+
config ATMEL_AIC_IRQ
bool
select GENERIC_IRQ_CHIP
diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile
index 16a5fd126c9a..de7be9803c74 100644
--- a/drivers/irqchip/Makefile
+++ b/drivers/irqchip/Makefile
@@ -4,7 +4,7 @@ obj-$(CONFIG_IRQCHIP) += irqchip.o
obj-$(CONFIG_AL_FIC) += irq-al-fic.o
obj-$(CONFIG_ALPINE_MSI) += irq-alpine-msi.o
obj-$(CONFIG_ATH79) += irq-ath79-cpu.o
-obj-$(CONFIG_ATH79) += irq-ath79-misc.o
+obj-$(CONFIG_ATH79_MISC_IRQ) += irq-ath79-misc.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o
obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o
obj-$(CONFIG_ARCH_ACTIONS) += irq-owl-sirq.o
diff --git a/drivers/irqchip/irq-ath79-misc.c b/drivers/irqchip/irq-ath79-misc.c
index b06ece446746..dc865dbbbc3b 100644
--- a/drivers/irqchip/irq-ath79-misc.c
+++ b/drivers/irqchip/irq-ath79-misc.c
@@ -16,7 +16,9 @@
#include <linux/module.h>
#include <linux/platform_device.h>
+#ifdef CONFIG_ATH79
#include <asm/time.h>
+#endif
#define AR71XX_RESET_REG_MISC_INT_STATUS 0
#define AR71XX_RESET_REG_MISC_INT_ENABLE 4
@@ -24,8 +26,14 @@
#define ATH79_MISC_IRQ_COUNT 32
#define ATH79_MISC_PERF_IRQ 5
+#ifdef CONFIG_ATH79
static struct irq_domain *ath79_misc_domain;
+static void ath79_misc_set_perf_domain(struct irq_domain *domain)
+{
+ ath79_misc_domain = domain;
+}
+
/* Called by the MIPS perf code when the first event is created. */
int get_c0_perfcount_int(void)
{
@@ -39,6 +47,9 @@ int get_c0_perfcount_int(void)
return irq ? irq : -1;
}
EXPORT_SYMBOL_GPL(get_c0_perfcount_int);
+#else
+static void ath79_misc_set_perf_domain(struct irq_domain *domain) { }
+#endif
static void ath79_misc_irq_handler(struct irq_desc *desc)
{
@@ -52,12 +63,6 @@ static void ath79_misc_irq_handler(struct irq_desc *desc)
pending = __raw_readl(base + AR71XX_RESET_REG_MISC_INT_STATUS) &
__raw_readl(base + AR71XX_RESET_REG_MISC_INT_ENABLE);
- if (!pending) {
- spurious_interrupt();
- chained_irq_exit(chip, desc);
- return;
- }
-
while (pending) {
int bit = __ffs(pending);
@@ -151,7 +156,7 @@ static int ath79_misc_intc_probe(struct platform_device *pdev)
__raw_writel(0, base + AR71XX_RESET_REG_MISC_INT_STATUS);
irq_set_chained_handler_and_data(irq, ath79_misc_irq_handler, domain);
- ath79_misc_domain = domain;
+ ath79_misc_set_perf_domain(domain);
return 0;
}
--
2.56.1
next prev parent reply other threads:[~2026-11-12 22:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 22:44 [PATCH 0/4] irqchip/ath79-misc: probe as a platform driver Rosen Penev
2026-11-12 22:44 ` [PATCH 1/4] MIPS: perf: look up the PMU interrupt when it is requested Rosen Penev
2026-11-12 22:55 ` sashiko-bot
2026-11-12 22:44 ` [PATCH 2/4] irqchip/ath79-misc: map the performance counter interrupt on demand Rosen Penev
2026-11-12 22:52 ` sashiko-bot
2026-11-12 22:44 ` [PATCH 3/4] irqchip/ath79-misc: convert to a platform driver Rosen Penev
2026-11-12 23:00 ` sashiko-bot
2026-11-12 22:44 ` Rosen Penev [this message]
2026-11-12 22:51 ` [PATCH 4/4] irqchip/ath79-misc: allow COMPILE_TEST builds sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112224445.213324-5-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox