Re: [DONE] Re: Reordering the thread output in perf trace --summary

[Milian Wolff <milian.wolff@kdab.com>]

[-- Attachment #1: Type: text/plain, Size: 2517 bytes --]

On Monday, May 9, 2016 1:25:16 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Mon, May 09, 2016 at 10:28:01AM +0200, Milian Wolff escreveu:
> > On Thursday, May 5, 2016 1:04:02 PM CEST Arnaldo Carvalho de Melo wrote:
> > > Em Wed, May 04, 2016 at 06:41:23PM -0300, Arnaldo Carvalho de Melo 
escreveu:
> > > > Em Wed, May 04, 2016 at 11:51:04AM +0200, Milian Wolff escreveu:
> > > > > On Wednesday, May 4, 2016 11:02:12 AM CEST Milian Wolff wrote:
> > > > > While at it, can we similarly reorder the output of the per-thread
> > > > > syscall
> > > > 
> > > > > list? At the moment it is e.g.:
> > > > Take a look at my perf/core branch, I have it working there.
> > > > 
> > > > I'm in the process of experimenting with creating some kinde of
> > > > template
> > > > for resorting rb_trees, that will reduce the boilerplace while keeping
> > > > it following the principles described in Documentation/rbtree.txt.
> > > 
> > > Ok, done, got really small and easy to change the keys if we want to,
> > > not dynamicly tho as-is now, but should be easy, with offsetof 8-)
> > > 
> > > Anyway, I'm satisfied and pushed to perf/core, now looking at why total
> > > thread time is zeroed...
> > > 
> > > Please take a look and check if it works for you,
> > 
> > Great Arnaldo, thanks a lot! A pleasant surprise to come home from a sunny
> > weekend and see this gem waiting for me :)
> > 
> > I played around with it, and it does work as advertised. Great work!
> 
> Glad you liked it :-)
> 
> I'll probably make it use the sched:sched_stat_runtime data as the sort
> key for threads if --stat is used, what do you think?

You mean if `--sched` was used? I'm undecided on this. On one hand, the user 
explicitly requests `--sched` so he probably is interested in it. On the other 
hand, the total number of syscalls or wait time per thread may be more 
interesting... If you use this to find contention issues e.g. then the threads 
suffering most from contention issues will have a low runtime.

Personally, I think this is yet another situation where a proper GUI could 
solve this problem nicely. A trivial tree view with the option to adapt the 
sorting and aggregation as needed and a way to filter out certain syscalls 
post-collection would be really nice to have. I'm very much looking forward to 
having more time at hands again to finally tackle this.

Bye
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]