Linux Perf Users
 help / color / mirror / Atom feed
From: Milian Wolff <milian.wolff@kdab.com>
To: "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Subject: Reordering the thread output in perf trace --summary
Date: Wed, 04 May 2016 11:02:12 +0200	[thread overview]
Message-ID: <91397949.qTd2kn5sDj@milian-kdab2> (raw)

[-- Attachment #1: Type: text/plain, Size: 2409 bytes --]

Hey all,

when using `perf trace --summary` on a (badly designed) user application that 
creates tons of threads, the usually interesting overall summary is drowned by 
the per-thread summary output. I.e.:

perf trace --summary lab_mandelbrot_concurrent |& grep events
 lab_mandelbrot_ (19497), 9246 events, 25.7%, 0.000 msec
 QXcbEventReader (19498), 1094 events, 3.0%, 0.000 msec
 QDBusConnection (19499), 132 events, 0.4%, 0.000 msec
 Thread (pooled) (19500), 1982 events, 5.5%, 0.000 msec
 Thread (pooled) (19501), 114 events, 0.3%, 0.000 msec
 lab_mandelbrot_ (19502), 88 events, 0.2%, 0.000 msec
 Thread (pooled) (19503), 106 events, 0.3%, 0.000 msec
 Thread (pooled) (19504), 101 events, 0.3%, 0.000 msec
 Thread (pooled) (19505), 102 events, 0.3%, 0.000 msec
... continued for a total of 163 lines

usually, I forget to pipe the output of `perf trace --summary` into a file and 
then have to rerun the command, as the total output (2643 lines!) easily 
exceeds my scrollback buffer.

I would like to propose to reorder the output to sort the output in ascending 
total event order, such that the most interesting output is shown at the 
bottom of the output on the CLI. I.e. in the output above it should be 
something like

perf trace --summary lab_mandelbrot_concurrent |& grep events
... continued for a total of 163 lines
 lab_mandelbrot_ (19502), 88 events, 0.2%, 0.000 msec
 Thread (pooled) (19501), 114 events, 0.3%, 0.000 msec
 Thread (pooled) (19503), 106 events, 0.3%, 0.000 msec
 Thread (pooled) (19504), 101 events, 0.3%, 0.000 msec
 Thread (pooled) (19505), 102 events, 0.3%, 0.000 msec
 QDBusConnection (19499), 132 events, 0.4%, 0.000 msec
 QXcbEventReader (19498), 1094 events, 3.0%, 0.000 msec
 Thread (pooled) (19500), 1982 events, 5.5%, 0.000 msec
 lab_mandelbrot_ (19497), 9246 events, 25.7%, 0.000 msec

If this is acceptable to you, can someone please tell me how to do such a 
seemingly simple task in C? In C++ I'd except to add a simple std::sort 
somewhere, but in perf's C...? My current idea would be to run 
machine__for_each_thread and store the even count + thread pointer in another 
temporary buffer, which I then qsort and finally iterate over. Does that sound 
OK, or how would you approach this task?

Thanks
-- 
Milian Wolff | milian.wolff@kdab.com | Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5903 bytes --]

             reply	other threads:[~2016-05-04  9:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  9:02 Milian Wolff [this message]
2016-05-04  9:51 ` Reordering the thread output in perf trace --summary Milian Wolff
2016-05-04 21:41   ` Arnaldo Carvalho de Melo
2016-05-05 16:04     ` [DONE] " Arnaldo Carvalho de Melo
2016-05-09  8:28       ` Milian Wolff
2016-05-09 16:25         ` Arnaldo Carvalho de Melo
2016-05-09 18:03           ` Milian Wolff
2016-05-09 20:12             ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91397949.qTd2kn5sDj@milian-kdab2 \
    --to=milian.wolff@kdab.com \
    --cc=linux-perf-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox