Linux Perf Users
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zide Chen <zide.chen@intel.com>,
	Falcon Thomas <thomas.falcon@intel.com>,
	Dapeng Mi <dapeng1.mi@intel.com>,
	Xudong Hao <xudong.hao@intel.com>
Subject: Re: [Patch v2 0/7] perf/x86: Miscellaneous PMU bug fixes and optimizations
Date: Wed, 15 Jul 2026 15:27:06 +0800	[thread overview]
Message-ID: <8fc9e992-ae58-4354-9b21-6c5ac02824ee@linux.intel.com> (raw)
In-Reply-To: <20260713082734.3162099-1-dapeng1.mi@linux.intel.com>

Hi Peter,

Not sure if you have bandwidth to review the patch-set? This patchset fixes
some recently found issues by Sashiko. Most of issues are error handling
related. Thanks.


On 7/13/2026 4:27 PM, Dapeng Mi wrote:
> Changes since v1:
> - Patch 3/7: Ensure cpuc->pmu is not the static pmu before calling
>   hybrid_pmu(cpuc->pmu) in intel_pmu_cpu_dead() (Sashiko).
>
> This series fixes recently found x86 core PMU bugs. Most of bugs are
> found by Sashiko in reviewing the "Support SIMD/eGPRs/SSP registers 
> sampling for perf" patch-set, e.g.,
> https://lore.kernel.org/all/20260706022123.480411F000E9@smtp.kernel.org/
> https://lore.kernel.org/all/20260706021852.DE2ED1F000E9@smtp.kernel.org/
>
> The last patch 7/7 optimizes ACR handling in match_prev_assignment() and
> mitigate the performance overhead.
>
> Tests:
> Below test cases are run on Diamonds and Novalake. No issues are found.
> - Perf stat test
>   $ perf test 119
> - Perf record tests 
>   $ perf test 155
> - Perf record LBR tests
>   $ perf test 156
>
> History:
> v1: https://lore.kernel.org/all/20260710065128.1799838-1-dapeng1.mi@linux.intel.com/
>
> Dapeng Mi (7):
>   perf/x86: Unregister PMI handler on PMU init failure
>   perf/x86: Free hybrid state on PMU init failure
>   perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU casts
>   perf/x86/intel: Unwind cpuc state if PEBS buffer setup fails
>   perf/x86: Remove stale fixed counter helper and fix hybrid PMU access
>   perf/x86/intel: Fix intel_cap handling on hybrid PMUs
>   perf/x86: Optimize ACR handling in match_prev_assignment()
>
>  arch/x86/events/core.c       | 45 +++++++++++++++++++-------
>  arch/x86/events/intel/core.c | 61 ++++++++++++++++++++++++++----------
>  arch/x86/events/perf_event.h | 12 ++-----
>  3 files changed, 81 insertions(+), 37 deletions(-)
>
>
> base-commit: edda9051e267b7390c7ce24b1b71434414ad156e

  parent reply	other threads:[~2026-07-15  7:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  8:27 [Patch v2 0/7] perf/x86: Miscellaneous PMU bug fixes and optimizations Dapeng Mi
2026-07-13  8:27 ` [Patch v2 1/7] perf/x86: Unregister PMI handler on PMU init failure Dapeng Mi
2026-07-13  8:27 ` [Patch v2 2/7] perf/x86: Free hybrid state " Dapeng Mi
2026-07-13  8:27 ` [Patch v2 3/7] perf/x86: Guard intel_pmu_cpu_dead() against invalid hybrid PMU casts Dapeng Mi
2026-07-13  8:59   ` sashiko-bot
2026-07-13  8:27 ` [Patch v2 4/7] perf/x86/intel: Unwind cpuc state if PEBS buffer setup fails Dapeng Mi
2026-07-13  8:27 ` [Patch v2 5/7] perf/x86: Remove stale fixed counter helper and fix hybrid PMU access Dapeng Mi
2026-07-13  8:27 ` [Patch v2 6/7] perf/x86/intel: Fix intel_cap handling on hybrid PMUs Dapeng Mi
2026-07-15 14:25   ` Falcon, Thomas
2026-07-13  8:27 ` [Patch v2 7/7] perf/x86: Optimize ACR handling in match_prev_assignment() Dapeng Mi
2026-07-15  7:27 ` Mi, Dapeng [this message]
2026-07-15 14:52 ` [Patch v2 0/7] perf/x86: Miscellaneous PMU bug fixes and optimizations Falcon, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fc9e992-ae58-4354-9b21-6c5ac02824ee@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@intel.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    --cc=xudong.hao@intel.com \
    --cc=zide.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox