* [PATCH] perf dwarf-regs: s390: Fix an off by one bug
@ 2026-04-23 7:07 Dan Carpenter
2026-04-23 10:03 ` Thomas Richter
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Dan Carpenter @ 2026-04-23 7:07 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
Change the > comparison to >= to prevent an out of bounds access of
the dwarf_s390_regnums[] array.
Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
index 310a37451bdc..f79216a7665a 100644
--- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
+++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
@@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
if (perf_regnum == 0)
return 0;
- if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
+ if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
dwarf_s390_regnums[perf_regnum] == 0)
return -ENOENT;
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug
2026-04-23 7:07 [PATCH] perf dwarf-regs: s390: Fix an off by one bug Dan Carpenter
@ 2026-04-23 10:03 ` Thomas Richter
2026-04-23 20:24 ` Ian Rogers
2026-04-24 7:02 ` Linus Probert
2 siblings, 0 replies; 6+ messages in thread
From: Thomas Richter @ 2026-04-23 10:03 UTC (permalink / raw)
To: Dan Carpenter, Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
On 4/23/26 09:07, Dan Carpenter wrote:
> Change the > comparison to >= to prevent an out of bounds access of
> the dwarf_s390_regnums[] array.
>
> Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> index 310a37451bdc..f79216a7665a 100644
> --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
> if (perf_regnum == 0)
> return 0;
>
> - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> dwarf_s390_regnums[perf_regnum] == 0)
> return -ENOENT;
>
Acked-by: Thomas Richter <tmricht@linux.ibm.com>
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Wolfgang Wendt
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug
2026-04-23 7:07 [PATCH] perf dwarf-regs: s390: Fix an off by one bug Dan Carpenter
2026-04-23 10:03 ` Thomas Richter
@ 2026-04-23 20:24 ` Ian Rogers
2026-04-23 20:27 ` Dan Carpenter
2026-04-24 7:02 ` Linus Probert
2 siblings, 1 reply; 6+ messages in thread
From: Ian Rogers @ 2026-04-23 20:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
On Thu, Apr 23, 2026 at 12:07 AM Dan Carpenter <error27@gmail.com> wrote:
>
> Change the > comparison to >= to prevent an out of bounds access of
> the dwarf_s390_regnums[] array.
>
> Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> index 310a37451bdc..f79216a7665a 100644
> --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
> if (perf_regnum == 0)
> return 0;
>
> - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
It looks like this mistake was copy-pasted into these files as well:
- tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
- tools/perf/util/dwarf-regs-arch/dwarf-regs-x86.c
- tools/perf/util/dwarf-regs-arch/dwarf-regs-powerpc.c
Could you fix them all?
Thanks,
Ian
> dwarf_s390_regnums[perf_regnum] == 0)
> return -ENOENT;
>
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug
2026-04-23 20:24 ` Ian Rogers
@ 2026-04-23 20:27 ` Dan Carpenter
2026-04-23 21:04 ` Ian Rogers
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2026-04-23 20:27 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
On Thu, Apr 23, 2026 at 01:24:50PM -0700, Ian Rogers wrote:
> On Thu, Apr 23, 2026 at 12:07 AM Dan Carpenter <error27@gmail.com> wrote:
> >
> > Change the > comparison to >= to prevent an out of bounds access of
> > the dwarf_s390_regnums[] array.
> >
> > Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > ---
> > tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > index 310a37451bdc..f79216a7665a 100644
> > --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
> > if (perf_regnum == 0)
> > return 0;
> >
> > - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> > + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
>
> It looks like this mistake was copy-pasted into these files as well:
> - tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
> - tools/perf/util/dwarf-regs-arch/dwarf-regs-x86.c
> - tools/perf/util/dwarf-regs-arch/dwarf-regs-powerpc.c
>
> Could you fix them all?
Sure. Do you want that as four separate patches or just one patch with
four Fixes tags?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug
2026-04-23 20:27 ` Dan Carpenter
@ 2026-04-23 21:04 ` Ian Rogers
0 siblings, 0 replies; 6+ messages in thread
From: Ian Rogers @ 2026-04-23 21:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
On Thu, Apr 23, 2026 at 1:28 PM Dan Carpenter <error27@gmail.com> wrote:
>
> On Thu, Apr 23, 2026 at 01:24:50PM -0700, Ian Rogers wrote:
> > On Thu, Apr 23, 2026 at 12:07 AM Dan Carpenter <error27@gmail.com> wrote:
> > >
> > > Change the > comparison to >= to prevent an out of bounds access of
> > > the dwarf_s390_regnums[] array.
> > >
> > > Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
> > > Signed-off-by: Dan Carpenter <error27@gmail.com>
> > > ---
> > > tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > > index 310a37451bdc..f79216a7665a 100644
> > > --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > > +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> > > @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
> > > if (perf_regnum == 0)
> > > return 0;
> > >
> > > - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> > > + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> >
> > It looks like this mistake was copy-pasted into these files as well:
> > - tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
> > - tools/perf/util/dwarf-regs-arch/dwarf-regs-x86.c
> > - tools/perf/util/dwarf-regs-arch/dwarf-regs-powerpc.c
> >
> > Could you fix them all?
>
> Sure. Do you want that as four separate patches or just one patch with
> four Fixes tags?
Probably the latter as it will make backports easier. Thanks!
Ian
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] perf dwarf-regs: s390: Fix an off by one bug
2026-04-23 7:07 [PATCH] perf dwarf-regs: s390: Fix an off by one bug Dan Carpenter
2026-04-23 10:03 ` Thomas Richter
2026-04-23 20:24 ` Ian Rogers
@ 2026-04-24 7:02 ` Linus Probert
2 siblings, 0 replies; 6+ messages in thread
From: Linus Probert @ 2026-04-24 7:02 UTC (permalink / raw)
To: Dan Carpenter, Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Guo Ren,
linux-perf-users, linux-kernel, kernel-janitors
On Thu Apr 23, 2026 at 9:07 AM CEST, Dan Carpenter wrote:
> Change the > comparison to >= to prevent an out of bounds access of
> the dwarf_s390_regnums[] array.
>
> Fixes: 1e452dd850f3 ("perf dwarf-regs: Add S390 perf to DWARF register number mapping functions")
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c | 1 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> index 310a37451bdc..f79216a7665a 100644
> --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-s390.c
> @@ -45,7 +45,7 @@ int __get_dwarf_regnum_for_perf_regnum_s390(int perf_regnum)
> if (perf_regnum == 0)
> return 0;
>
> - if (perf_regnum < 0 || perf_regnum > (int)ARRAY_SIZE(dwarf_s390_regnums) ||
> + if (perf_regnum < 0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_s390_regnums) ||
^^
Why leave the two spaces?
> dwarf_s390_regnums[perf_regnum] == 0)
> return -ENOENT;
>
Br,
Linus
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-04-24 7:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-23 7:07 [PATCH] perf dwarf-regs: s390: Fix an off by one bug Dan Carpenter
2026-04-23 10:03 ` Thomas Richter
2026-04-23 20:24 ` Ian Rogers
2026-04-23 20:27 ` Dan Carpenter
2026-04-23 21:04 ` Ian Rogers
2026-04-24 7:02 ` Linus Probert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox